Warn about HTML within SVG tags#13516
Closed
alex-saunders wants to merge 5 commits intofacebook:masterfrom
Closed
Conversation
Details of bundled changes.Comparing: 1664b08...91ac38d react-dom
Generated by 🚫 dangerJS |
gaearon
reviewed
Aug 30, 2018
| case 'h5': | ||
| case 'h6': | ||
| return ancestorInfo.pTagInButtonScope; | ||
| return ( |
Collaborator
There was a problem hiding this comment.
These checks all look very similar, is there a refactoring you can do to make the logic clearer?
Author
There was a problem hiding this comment.
I've tried putting it into a variable to avoid the repeated code
ctrlaltvikas
approved these changes
Sep 1, 2018
Simek
suggested changes
Sep 17, 2018
| return ancestorInfo.pTagInButtonScope || isValidHtmlInSvg; | ||
|
|
||
| case 'span': | ||
| return !ancestorInfo.foreignObjectInScope |
Contributor
There was a problem hiding this comment.
One more code piece (span case) which could be replaced with isValidHtmlInSvg.
Simek
approved these changes
Sep 28, 2018
Author
|
CI is saying that this PR is failing tests but they all complete successfully on my machine, any ideas as to why this might be happening? |
alex-saunders
force-pushed
the
no-html-in-svg
branch
from
98ad03d to
e302cfa
Compare
Size changes (experimental)Details of bundled changes.Comparing: 4eeee35...e302cfa react-dom
|
Size changes (stable)Details of bundled changes.Comparing: 4eeee35...e302cfa react-dom
|
Author
|
@gaearon I've revisited this PR & rebased to help all checks pass, do you think this is something we could look at again for merging? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to warn about nesting non-SVG HTML tags within SVG (similar to how developers are warned against nesting
<p>tags within<p>tags).Example:
Produces the following warning:
However, including the
<div>within a<foreignObject>Produces no errors message.
Ideally, I think the warning should include some messaging about wrapping HTML inside a foreignObject, i.e. '
<div>cannot appear as a descendant of<svg>, consider wrapping it inside a<foreignObject>', but I wasn't 100% sure on how to implement this with howvalidateDOMNesting.jscurrently works.closes #11013