Add support for empty XJS expressions#136
Merged
zpao merged 1 commit intofacebook:masterfrom Jun 28, 2013
Merged
Conversation
zpao
added a commit
that referenced
this pull request
Jun 28, 2013
Add support for empty XJS expressions
bvaughn
pushed a commit
to bvaughn/react
that referenced
this pull request
Aug 13, 2019
remove the `background` permissions as it's not used by Firefox, but `activeTab` is and we needed it. fix facebook#136
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for empty expressions so that something like this is now possible:
`
This then becomes a good way of commenting within a JSX child declaration body
See #82