Skip to content

Manually update schedule dep in react-native-renderer#13609

Merged
bvaughn merged 1 commit intofacebook:masterfrom
bvaughn:update-react-native-renderer-package-dep
Sep 10, 2018
Merged

Manually update schedule dep in react-native-renderer#13609
bvaughn merged 1 commit intofacebook:masterfrom
bvaughn:update-react-native-renderer-package-dep

Conversation

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Sep 10, 2018

The build script didn't update this package.json because of the private: true flag. Running yarn install in the React repo will complain now though because of the mismatch.

@gaearon
Copy link
Collaborator

gaearon commented Sep 10, 2018

The build script didn't update this package.json because of the private: true flag.

Should we make it do so?

@pull-bot
Copy link

Details of bundled changes.

Comparing: 03ab1ef...87cb97e

schedule

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
schedule.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
schedule.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@bvaughn
Copy link
Contributor Author

bvaughn commented Sep 10, 2018

Yeah. It's an edge case I guess, but I will update it to do that here shortly.

@bvaughn bvaughn merged commit ade5e69 into facebook:master Sep 10, 2018
@bvaughn bvaughn deleted the update-react-native-renderer-package-dep branch September 10, 2018 18:07
Simek pushed a commit to Simek/react that referenced this pull request Oct 25, 2018
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants