Skip to content

[reconciler] ReactFiberNewContext import maxSigned31BitInt twice #13857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nhunzaker merged 3 commits into from
Oct 22, 2018
Merged

[reconciler] ReactFiberNewContext import maxSigned31BitInt twice #13857

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5708f2d
[reconciler] ReactFiberNewContext import maxSigned31BitInt twice
yongningfu Oct 16, 2018
b58e3b5
Merge branch 'master' into ReactFiberNewContext-dev
yongningfu Oct 22, 2018
86f8a40
rename maxSigned31BitInt to MAX_SIGNED_31_BIT_INT
yongningfu Oct 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/react-reconciler/src/ReactFiberNewContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export type ContextDependency<T> = {
import warningWithoutStack from 'shared/warningWithoutStack';
import {isPrimaryRenderer} from './ReactFiberHostConfig';
import {createCursor, push, pop} from './ReactFiberStack';
import maxSigned31BitInt from './maxSigned31BitInt';
import MAX_SIGNED_31_BIT_INT from './maxSigned31BitInt';
import {NoWork} from './ReactFiberExpirationTime';
import {ContextProvider, ClassComponent} from 'shared/ReactWorkTags';

Expand All @@ -33,7 +33,6 @@ import {
ForceUpdate,
} from 'react-reconciler/src/ReactUpdateQueue';

import MAX_SIGNED_31_BIT_INT from './maxSigned31BitInt';
const valueCursor: StackCursor<mixed> = createCursor(null);

let rendererSigil;
Expand Down Expand Up @@ -277,11 +276,11 @@ export function readContext<T>(
let resolvedObservedBits; // Avoid deopting on observable arguments or heterogeneous types.
if (
typeof observedBits !== 'number' ||
observedBits === maxSigned31BitInt
observedBits === MAX_SIGNED_31_BIT_INT
) {
// Observe all updates.
lastContextWithAllBitsObserved = ((context: any): ReactContext<mixed>);
resolvedObservedBits = maxSigned31BitInt;
resolvedObservedBits = MAX_SIGNED_31_BIT_INT;
} else {
resolvedObservedBits = observedBits;
}
Expand Down