[Fresh] Support lazy() and add Suspense tests#15681
Merged
gaearon merged 3 commits intofacebook:masterfrom May 20, 2019
Merged
Conversation
threepointone
approved these changes
May 20, 2019
Contributor
threepointone
left a comment
threepointone
left a comment
There was a problem hiding this comment.
looks fine overall, shipit.
| return App; | ||
| }); | ||
|
|
||
| expect(container.textContent).toBe('Loading'); |
Contributor
There was a problem hiding this comment.
why not use act() for this?
(and a couple more further down)
Collaborator
Author
There was a problem hiding this comment.
I thought act doesn't flush Suspense. I need recipes :P
Contributor
There was a problem hiding this comment.
replace
jest.runAllTimers();
await promise;
Scheduler.flushAll();with
await act(async () => {
jest.runAllTimers()
})in general, we shouldn't have to call Scheduler.flushAll() by hand
gaearon
added a commit
to gaearon/react
that referenced
this pull request
Jun 11, 2019
* Test that state is not leaked between components * Support lazy and add Suspense tests * Nits
gaearon
added a commit
to gaearon/react
that referenced
this pull request
Jun 19, 2019
* Test that state is not leaked between components * Support lazy and add Suspense tests * Nits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a TODO about supporting
lazy.For now this only lets you edit a file wrapped with
lazy— but not the file usinglazy. That would still need some follow-up work.Also adds test coverage for hot reloading Suspended trees.