[Flare] Account for fixed elements in getAbsoluteBoundingClientRect#15707
Merged
trueadm merged 3 commits intofacebook:masterfrom May 22, 2019
Merged
[Flare] Account for fixed elements in getAbsoluteBoundingClientRect#15707trueadm merged 3 commits intofacebook:masterfrom
trueadm merged 3 commits intofacebook:masterfrom
Conversation
necolas
approved these changes
May 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This alter's the Press event responder so it can properly account for fixed elements that have scrollable regions. I've added inline comments explaining the logic and also tested this internally and it fixes a bunch of bugs.