Update sizebot to match name of CircleCI build job#15714
Merged
acdlite merged 1 commit intofacebook:masterfrom May 22, 2019
Merged
Update sizebot to match name of CircleCI build job#15714acdlite merged 1 commit intofacebook:masterfrom
acdlite merged 1 commit intofacebook:masterfrom
Conversation
The sizebot scrapes the GitHub `/statuses` endpoint to get the lastest CircleCI build number for master, in order to fetch the bundle size info for that build, which are stored as build artifacts. (There's gotta be a better way to do this, but that's what we have for now.) This updates the script to match the name of the updated CircleCI job that generates the bundle sizes.
acdlite
force-pushed
the
update-sizebot
branch
5 times, most recently
from
1b113d1 to
d0e37bd
Compare
acdlite
force-pushed
the
update-sizebot
branch
3 times, most recently
from
6f45c5b to
8a985d6
Compare
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
acdlite
added a commit
to acdlite/react
that referenced
this pull request
May 29, 2019
Same as facebook#15714. I moved the artifacts step to a different job, so I need to update the name in the sizebot script to match.
acdlite
added a commit
to acdlite/react
that referenced
this pull request
May 29, 2019
Same as facebook#15714. I moved the artifacts step to a different job, so I need to update the name in the sizebot script to match.
acdlite
added a commit
that referenced
this pull request
May 29, 2019
Same as #15714. I moved the artifacts step to a different job, so I need to update the name in the sizebot script to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sizebot scrapes the GitHub
/statusesendpoint to get the latest CircleCI build number for master, in order to fetch the bundle size info for that build, which are stored as build artifacts. (There's gotta be a better way to do this, but that's what we have for now.) This updates the script to match the name of the updated CircleCI job that generates the bundle sizes.