Skip to content

[Scheduler][Bugfix] Multiple rAFs in same frame #16184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acdlite merged 1 commit into from
Jul 23, 2019
Merged

[Scheduler][Bugfix] Multiple rAFs in same frame #16184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/scheduler/src/forks/SchedulerHostConfig.default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,10 @@ if (
channel.port1.onmessage = performWorkUntilDeadline;

const onAnimationFrame = rAFTime => {
isRAFLoopRunning = false;

if (scheduledHostCallback === null) {
// No scheduled work. Exit.
isRAFLoopRunning = false;
prevRAFTime = -1;
prevRAFInterval = -1;
return;
Expand All @@ -255,6 +256,7 @@ if (
// waited until the end of the frame to post the callback, we risk the
// browser skipping a frame and not firing the callback until the frame
// after that.
isRAFLoopRunning = true;
requestAnimationFrame(nextRAFTime => {
clearTimeout(rAFTimeoutID);
onAnimationFrame(nextRAFTime);
Expand Down Expand Up @@ -303,9 +305,8 @@ if (
requestHostCallback = function(callback) {
scheduledHostCallback = callback;
if (!isRAFLoopRunning) {
isRAFLoopRunning = true;

// Start a rAF loop.
isRAFLoopRunning = true;
requestAnimationFrame(rAFTime => {
if (requestIdleCallbackBeforeFirstFrame) {
cancelIdleCallback(idleCallbackID);
Expand Down