Skip to content

[react-devtools] Enable to display Long interaction names(#16736)#16767

Closed
toshi1127 wants to merge 1 commit intofacebook:masterfrom
toshi1127:feature/display-long-interaction-name
Closed

[react-devtools] Enable to display Long interaction names(#16736)#16767
toshi1127 wants to merge 1 commit intofacebook:masterfrom
toshi1127:feature/display-long-interaction-name

Conversation

@toshi1127
Copy link
Copy Markdown

issues: #16736

fixed long interaction names displayable.
スクリーンショット 2019-09-13 3 44 22

@toshi1127
Copy link
Copy Markdown
Author

I have completed the Contributor License Agreement.

@toshi1127 toshi1127 changed the title [dev-tool-extension] Enable to display Long interaction names(#16736) [react-devtools] Enable to display Long interaction names(#16736) Sep 12, 2019
@sizebot
Copy link
Copy Markdown

sizebot commented Sep 12, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against ce20e83

@lekterable
Copy link
Copy Markdown

Hey @toshi1127 , huge thanks for your contribution, but if you could next time let know in the thread that you're taking the issue it will save us the unnecessary confusion. @varenaggarwal might've started to work on it as well, as it didn't look taken.

@toshi1127
Copy link
Copy Markdown
Author

@lekterable
I'm sorry, that's true.
As a precaution, I posted that I worked on the issue.

Copy link
Copy Markdown

@erasmuswill erasmuswill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@souravbadami
Copy link
Copy Markdown

souravbadami commented Oct 24, 2019

Why is this pending? Is something left out?
Please let me know. I was going through the list of issues and found this.

@bvaughn
Copy link
Copy Markdown
Contributor

bvaughn commented Dec 22, 2019

Thank you for opening a PR!

I don't think horizontally scrolling text is a very user friendly interface though. I think adding a tooltip (via a title attribute) to the sidebar is a sufficient change. (One was already added to the main list item.)

You can also triple click the interaction name to select it all (despite the truncation ellipsis).

I'll make sure the new tooltip gets added (via PR #17689).

@bvaughn bvaughn closed this Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.