Skip to content

Update release scripts to support experimental releases #17086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acdlite merged 2 commits into from
Oct 14, 2019
Merged

Update release scripts to support experimental releases #17086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cec646f
Download correct artifacts for release channel
acdlite Oct 14, 2019
9feaba7
Prevent experimental promotion to stable
acdlite Oct 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions scripts/release/prepare-stable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const printPrereleaseSummary = require('./shared-commands/print-prerelease-summa
const testPackagingFixture = require('./shared-commands/test-packaging-fixture');
const testTracingFixture = require('./shared-commands/test-tracing-fixture');
const updateStableVersionNumbers = require('./prepare-stable-commands/update-stable-version-numbers');
const theme = require('./theme');

const run = async () => {
try {
Expand All @@ -30,6 +31,13 @@ const run = async () => {
params.version = await getLatestCanaryVersion();
}

if (params.version.includes('experimental')) {
console.error(
theme.error`Cannot promote an experimental build to stable.`
);
process.exit(1);
}

await checkOutPackages(params);
await guessStableVersionNumbers(params, versionsMap);
await confirmStableVersionNumbers(params, versionsMap);
Expand Down
10 changes: 7 additions & 3 deletions scripts/release/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,22 @@ const getArtifactsList = async buildID => {
);
process.exit(1);
}

const artifactsJobName = buildMetadata.workflows.job_name.endsWith(
'_experimental'
)
? 'process_artifacts_experimental'
: 'process_artifacts';
const workflowID = buildMetadata.workflows.workflow_id;
const workflowMetadataURL = `https://circleci.com/api/v2/workflow/${workflowID}/jobs?circle-token=${
process.env.CIRCLE_CI_API_TOKEN
}`;
const workflowMetadata = await http.get(workflowMetadataURL, true);
const job = workflowMetadata.items.find(
({name}) => name === 'process_artifacts'
({name}) => name === artifactsJobName
);
if (!job || !job.job_number) {
console.log(
theme`{error Could not find "process_artifacts" job for workflow ${workflowID}.}`
theme`{error Could not find "${artifactsJobName}" job for workflow ${workflowID}.}`
);
process.exit(1);
}
Expand Down