[react-interactions] Remove batchedUpdates from responder lifecycles#17659
Merged
trueadm merged 1 commit intofacebook:masterfrom Dec 19, 2019
Merged
[react-interactions] Remove batchedUpdates from responder lifecycles#17659trueadm merged 1 commit intofacebook:masterfrom
trueadm merged 1 commit intofacebook:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6406924:
|
Details of bundled changes.Comparing: 4c27037...6406924 react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
necolas
approved these changes
Dec 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
batchedUpdateswrapper from the Flare Responder lifecycle events – specificallyonMountandonUnmount. The intention of having them here, was in case the responder dispatched user events that triggered state updates, which isn't the case.By making this change, we fix an interesting bug to do with controlled components and inputting multi-byte characters in other languages.
batchedUpdateshas an interesting side-effect in that it callsfinishEventHandlerwhich in turn restores controlled component state and callsflushDiscreteUpdatesImpl, which is what causes this bug.