[react-interactions] Fix Hover issues with portals#17765
Merged
trueadm merged 1 commit intofacebook:masterfrom Jan 7, 2020
Merged
[react-interactions] Fix Hover issues with portals#17765trueadm merged 1 commit intofacebook:masterfrom
trueadm merged 1 commit intofacebook:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5f3d462:
|
Details of bundled changes.Comparing: cca994c...5f3d462 react-interactions
Size changes (stable) |
Details of bundled changes.Comparing: cca994c...5f3d462 react-interactions
Size changes (experimental) |
necolas
approved these changes
Jan 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue discovered internally with the Hover responder and React Portals. Specifically, the
onHoverEndevents were not firing when we moved focus through a React Portal. The reason for this is because, by their nature, portal nodes are within other parts of the DOM tree, that are not linked to that of the "target" portion of the tree. That means, moving into a portal will be the last time we get apointerleaveevent fire because we only trackpointerleavefor target events. We should instead be tracking this for root events, as portals are in another part of the document. I've also added a regression test that shows this error (will fail if you revert Hover.js).