Remove .internal from more test suites#18597
Merged
Merged
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9f000d3:
|
acdlite
force-pushed
the
remove-internal
branch
from
9b81e53 to
3571729
Compare
acdlite
force-pushed
the
remove-internal
branch
2 times, most recently
from
2ada58c to
26033ed
Compare
acdlite
commented
Apr 14, 2020
Comment on lines
+60
to
+61
| export const scheduleTimeout = $$$hostConfig.scheduleTimeout; | ||
| export const cancelTimeout = $$$hostConfig.cancelTimeout; |
Collaborator
Author
There was a problem hiding this comment.
Welp turns out react-reconciler didn't work with Suspense!
acdlite
force-pushed
the
remove-internal
branch
from
26033ed to
9f000d3
Compare
lunaruan
approved these changes
Apr 14, 2020
gaearon
approved these changes
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the tests to run against the actual build artifacts