Add helper getDefaultView for IE8#1895
Closed
syranide wants to merge 1 commit intofacebook:masterfrom
syranide:ie8defaultview
Closed
Add helper getDefaultView for IE8#1895syranide wants to merge 1 commit intofacebook:masterfrom syranide:ie8defaultview
syranide wants to merge 1 commit intofacebook:masterfrom
syranide:ie8defaultview
Conversation
Contributor
Author
|
Related discussion: #1901 #1885 (comment) |
Contributor
Author
|
This is probably too extreme for such a simple workaround. Continued at #1901 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an IE8 only workaround that is used in two places, lets put it in a helper instead so it's easier to spot when we stop supporting IE8. Or perhaps we should explicitly comment in both places that
parentWindowis a fallback for IE8.