Skip to content

Add unstable_isNewReconciler to dispatcher#18975

Merged
acdlite merged 1 commit into
facebook:masterfrom
acdlite:is-new-reconciler-dispatcher
May 21, 2020
Merged

Add unstable_isNewReconciler to dispatcher#18975
acdlite merged 1 commit into
facebook:masterfrom
acdlite:is-new-reconciler-dispatcher

Conversation

@acdlite
Copy link
Copy Markdown
Collaborator

@acdlite acdlite commented May 21, 2020

This is a bit gross but I need to be able to access it without importing the renderer.

There might be a better way but I need this to unblock an internal bugfix.

@acdlite
Add unstable_isNewReconciler to dispatcher
4ef7564 
This is a bit gross but I need to be able to access it without importing
the renderer.

There might be a better way but I need this to unblock internal bugfix.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 21, 2020
@acdlite acdlite merged commit 74394aa into facebook:master May 21, 2020
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented May 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4ef7564:

Sandbox Source
funny-mcclintock-z6xdm Configuration

@sizebot
Copy link
Copy Markdown

sizebot commented May 21, 2020

Details of bundled changes.

Comparing: 099f737...4ef7564

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-dev.js +0.1% 0.0% 643.3 KB 643.73 KB 138.02 KB 138.07 KB RN_OSS_DEV
ReactNativeRenderer-dev.js +0.1% 0.0% 662.16 KB 662.59 KB 142.53 KB 142.57 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 0.0% 0.0% 272.19 KB 272.32 KB 47.02 KB 47.03 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 284.24 KB 284.37 KB 49.32 KB 49.33 KB RN_OSS_PROFILING
ReactFabric-prod.js 🔺+0.1% 0.0% 264.1 KB 264.23 KB 45.5 KB 45.51 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 276.12 KB 276.25 KB 47.79 KB 47.8 KB RN_OSS_PROFILING

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOM-profiling.js 0.0% 0.0% 455.11 KB 455.24 KB 80.44 KB 80.45 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 136.36 KB 136.36 KB 34.88 KB 34.88 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.2% 1.16 KB 1.16 KB 660 B 661 B NODE_PROD
ReactDOMForked-dev.js 0.0% 0.0% 1.04 MB 1.04 MB 237.95 KB 237.99 KB FB_WWW_DEV
ReactDOMForked-prod.js 0.0% 0.0% 441.23 KB 441.36 KB 79.61 KB 79.61 KB FB_WWW_PROD
react-dom.development.js +0.1% 0.0% 913.38 KB 913.85 KB 200.75 KB 200.8 KB UMD_DEV
ReactDOMForked-profiling.js 0.0% 0.0% 451.83 KB 451.96 KB 81.35 KB 81.37 KB FB_WWW_PROFILING
react-dom.production.min.js 🔺+0.1% 🔺+0.2% 120.01 KB 120.12 KB 38.49 KB 38.57 KB UMD_PROD
react-dom.profiling.min.js +0.1% +0.1% 124 KB 124.11 KB 39.76 KB 39.79 KB UMD_PROFILING
ReactDOMTesting-dev.js 0.0% 0.0% 957.98 KB 958.38 KB 213.99 KB 214.02 KB FB_WWW_DEV
react-dom.development.js +0.1% 0.0% 869.42 KB 869.88 KB 198.22 KB 198.27 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 405.08 KB 405.21 KB 74.65 KB 74.65 KB FB_WWW_PROD
react-dom.production.min.js 🔺+0.1% 0.0% 120.13 KB 120.25 KB 37.59 KB 37.61 KB NODE_PROD
react-dom.profiling.min.js +0.1% 0.0% 124.25 KB 124.36 KB 38.85 KB 38.87 KB NODE_PROFILING
ReactDOM-dev.js 0.0% 0.0% 1.03 MB 1.04 MB 235.68 KB 235.71 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 443.58 KB 443.71 KB 78.53 KB 78.54 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% 0.0% 70.46 KB 70.46 KB 19.73 KB 19.73 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.6 KB 5.6 KB 1.86 KB 1.86 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.19 KB 1.19 KB 698 B 699 B UMD_PROD
ReactDOMServer-dev.js 0.0% -0.0% 147.39 KB 147.39 KB 37.46 KB 37.46 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 47.57 KB 47.57 KB 11.14 KB 11.14 KB FB_WWW_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js +0.1% +0.1% 614.04 KB 614.57 KB 129.29 KB 129.37 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.1% 0.0% 249.51 KB 249.64 KB 42.65 KB 42.66 KB FB_WWW_PROD
react-art.development.js +0.1% 0.0% 640.53 KB 641 KB 135.32 KB 135.37 KB UMD_DEV
react-art.production.min.js 🔺+0.1% 🔺+0.1% 107.62 KB 107.73 KB 32.67 KB 32.69 KB UMD_PROD
react-art.development.js +0.1% 0.0% 544.54 KB 545 KB 117.77 KB 117.82 KB NODE_DEV
react-art.production.min.js 🔺+0.2% 🔺+0.1% 72.61 KB 72.72 KB 21.82 KB 21.83 KB NODE_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactTestRenderer-dev.js +0.1% 0.0% 577.96 KB 578.39 KB 122.5 KB 122.54 KB FB_WWW_DEV
react-test-renderer-shallow.production.min.js 0.0% 🔺+0.1% 12.73 KB 12.73 KB 3.96 KB 3.97 KB UMD_PROD
react-test-renderer.development.js +0.1% 0.0% 577.37 KB 577.82 KB 120.54 KB 120.59 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.1% 74.71 KB 74.82 KB 22.75 KB 22.77 KB UMD_PROD
react-test-renderer.development.js +0.1% 0.0% 550.51 KB 550.94 KB 119.11 KB 119.16 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.1% 74.51 KB 74.62 KB 22.45 KB 22.47 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.1% 0.0% 598.12 KB 598.58 KB 127 KB 127.05 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.1% 🔺+0.1% 81.55 KB 81.66 KB 24.39 KB 24.41 KB NODE_PROD

Size changes (stable)

Generated by 🚫 dangerJS against 4ef7564

@sizebot
Copy link
Copy Markdown

sizebot commented May 21, 2020

Details of bundled changes.

Comparing: 099f737...4ef7564

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOMTesting-dev.js 0.0% 0.0% 932.19 KB 932.58 KB 208.31 KB 208.34 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.2 KB 1.2 KB 705 B 706 B UMD_PROD
react-dom.development.js +0.1% 0.0% 947.25 KB 947.72 KB 207.23 KB 207.28 KB UMD_DEV
react-dom.production.min.js 🔺+0.1% 0.0% 124.8 KB 124.91 KB 39.98 KB 40 KB UMD_PROD
ReactDOMForked-dev.js 0.0% 0.0% 1.01 MB 1.01 MB 232.12 KB 232.15 KB FB_WWW_DEV
react-dom.profiling.min.js +0.1% +0.1% 128.9 KB 129.01 KB 41.2 KB 41.23 KB UMD_PROFILING
ReactDOMForked-prod.js 0.0% 0.0% 430.04 KB 430.17 KB 77.72 KB 77.73 KB FB_WWW_PROD
react-dom.development.js +0.1% 0.0% 901.84 KB 902.3 KB 204.65 KB 204.7 KB NODE_DEV
ReactDOMForked-profiling.js 0.0% 0.0% 440.58 KB 440.71 KB 79.47 KB 79.48 KB FB_WWW_PROFILING
react-dom.production.min.js 🔺+0.1% 0.0% 124.98 KB 125.09 KB 39.04 KB 39.06 KB NODE_PROD
react-dom.profiling.min.js +0.1% 0.0% 129.24 KB 129.35 KB 40.37 KB 40.39 KB NODE_PROFILING
ReactDOM-dev.js 0.0% 0.0% 1.01 MB 1.01 MB 229.99 KB 230.01 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 432.5 KB 432.64 KB 76.68 KB 76.69 KB FB_WWW_PROD
ReactDOM-profiling.js 0.0% 0.0% 443.97 KB 444.11 KB 78.59 KB 78.6 KB FB_WWW_PROFILING
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.61 KB 5.61 KB 1.87 KB 1.87 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 393.23 KB 393.36 KB 72.74 KB 72.75 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.87 KB 4.87 KB 1.71 KB 1.7 KB NODE_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% 0.0% 664.92 KB 665.39 KB 140.23 KB 140.28 KB UMD_DEV
react-art.production.min.js 🔺+0.1% 🔺+0.1% 110.98 KB 111.09 KB 33.63 KB 33.65 KB UMD_PROD
react-art.development.js +0.1% 0.0% 567.93 KB 568.39 KB 122.71 KB 122.76 KB NODE_DEV
react-art.production.min.js 🔺+0.1% 🔺+0.1% 75.93 KB 76.04 KB 22.82 KB 22.85 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 604.02 KB 604.55 KB 127.26 KB 127.35 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.1% 0.0% 242.47 KB 242.6 KB 41.41 KB 41.42 KB FB_WWW_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer-shallow.production.min.js 0.0% 0.0% 12.74 KB 12.74 KB 3.97 KB 3.97 KB UMD_PROD
ReactTestRenderer-dev.js +0.1% 0.0% 577.97 KB 578.4 KB 122.51 KB 122.55 KB FB_WWW_DEV
react-test-renderer.development.js +0.1% 0.0% 577.4 KB 577.84 KB 120.56 KB 120.6 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.1% 74.74 KB 74.85 KB 22.77 KB 22.79 KB UMD_PROD
react-test-renderer.development.js +0.1% 0.0% 550.53 KB 550.96 KB 119.12 KB 119.17 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.1% 🔺+0.1% 74.54 KB 74.65 KB 22.47 KB 22.49 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.1% 0.0% 623.89 KB 624.35 KB 132.44 KB 132.48 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.1% 🔺+0.1% 85.29 KB 85.39 KB 25.48 KB 25.5 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-prod.js 🔺+0.1% 0.0% 264.11 KB 264.24 KB 45.51 KB 45.52 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 276.13 KB 276.27 KB 47.8 KB 47.81 KB RN_OSS_PROFILING
ReactNativeRenderer-prod.js 0.0% 0.0% 272.2 KB 272.33 KB 47.03 KB 47.04 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 284.25 KB 284.38 KB 49.33 KB 49.34 KB RN_OSS_PROFILING
ReactNativeRenderer-dev.js +0.1% 0.0% 666.65 KB 667.08 KB 143.21 KB 143.25 KB RN_FB_DEV
ReactNativeRenderer-prod.js 0.0% 0.0% 272.16 KB 272.29 KB 47.01 KB 47.02 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 284.2 KB 284.33 KB 49.3 KB 49.32 KB RN_FB_PROFILING
ReactFabric-dev.js +0.1% 0.0% 643.32 KB 643.74 KB 138.03 KB 138.08 KB RN_OSS_DEV
ReactFabric-dev.js +0.1% 0.0% 647.8 KB 648.23 KB 138.7 KB 138.75 KB RN_FB_DEV
ReactFabric-prod.js 🔺+0.1% 0.0% 264.07 KB 264.21 KB 45.5 KB 45.51 KB RN_FB_PROD
ReactNativeRenderer-dev.js +0.1% 0.0% 662.17 KB 662.6 KB 142.54 KB 142.58 KB RN_OSS_DEV
ReactFabric-profiling.js 0.0% 0.0% 276.09 KB 276.23 KB 47.78 KB 47.79 KB RN_FB_PROFILING

Size changes (experimental)

Generated by 🚫 dangerJS against 4ef7564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaearon gaearon gaearon approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@acdlite @sizebot @gaearon @facebook-github-bot