Skip to content

Move Scope API ref resolution to mutation phase#19264

Merged
trueadm merged 3 commits into
facebook:masterfrom
trueadm:resolve-scope-refs-in-mutation
Jul 8, 2020
Merged

Move Scope API ref resolution to mutation phase#19264
trueadm merged 3 commits into
facebook:masterfrom
trueadm:resolve-scope-refs-in-mutation

Conversation

@trueadm
Copy link
Copy Markdown
Contributor

@trueadm trueadm commented Jul 6, 2020

To unblock internal progression on replacing React Flare, let's instead move resolution of Scope API refs to the mutation phase, so we can attach event listeners to scopes before the layout phase begins.

@trueadm trueadm requested review from bvaughn and sebmarkbage July 6, 2020 19:53
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 6, 2020
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Jul 6, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit db1242c:

Sandbox Source
React Configuration

@sizebot
Copy link
Copy Markdown

sizebot commented Jul 6, 2020 •
edited
Loading

Details of bundled changes.

Comparing: c7805b8...db1242c

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 913.4 KB 913.42 KB 207.66 KB 207.66 KB NODE_DEV
ReactDOMForked-prod.js 0.0% 0.0% 392.79 KB 392.9 KB 73.1 KB 73.13 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% 0.0% 138.84 KB 138.84 KB 36.68 KB 36.68 KB NODE_DEV
ReactDOMForked-profiling.js 0.0% 0.0% 403.32 KB 403.52 KB 74.84 KB 74.86 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 145.04 KB 145.04 KB 36.88 KB 36.88 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.71 KB 20.71 KB 7.67 KB 7.67 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 10.35 KB 10.35 KB 4.07 KB 4.07 KB UMD_PROD
ReactDOMTesting-dev.js 0.0% 0.0% 952.77 KB 953.16 KB 213.6 KB 213.67 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 51.15 KB 51.15 KB 14.9 KB 14.9 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 398.65 KB 398.69 KB 75.4 KB 75.42 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.61 KB 5.61 KB 1.87 KB 1.86 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.2 KB 10.2 KB 3.99 KB 3.99 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 5.36 KB 5.36 KB 1.81 KB 1.8 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.17 KB 1.17 KB 666 B 668 B NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 4.87 KB 4.87 KB 1.7 KB 1.71 KB NODE_DEV
react-dom.development.js 0.0% 0.0% 959.4 KB 959.42 KB 210.21 KB 210.21 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 123.43 KB 123.43 KB 40.42 KB 40.42 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 127.38 KB 127.38 KB 41.62 KB 41.62 KB UMD_PROFILING
ReactDOMForked-dev.js 0.0% 0.0% 974.04 KB 974.42 KB 217.75 KB 217.83 KB FB_WWW_DEV
ReactDOM-dev.js 0.0% 0.0% 987.95 KB 988.34 KB 219.99 KB 220.06 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 397.73 KB 397.84 KB 74.06 KB 74.09 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 137.57 KB 137.57 KB 36.43 KB 36.43 KB NODE_DEV
ReactDOM-profiling.js 0.0% 0.0% 408.26 KB 408.46 KB 75.84 KB 75.84 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 20.29 KB 20.29 KB 7.52 KB 7.52 KB NODE_PROD
ReactDOMServer-dev.js 0.0% -0.0% 143.33 KB 143.33 KB 36.42 KB 36.42 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 55.53 KB 55.53 KB 15.37 KB 15.37 KB UMD_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js 0.0% 0.0% 245.22 KB 245.28 KB 43.44 KB 43.45 KB FB_WWW_PROD
react-art.development.js 0.0% 0.0% 689.54 KB 689.56 KB 146.17 KB 146.17 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 112.52 KB 112.52 KB 34.82 KB 34.82 KB UMD_PROD
react-art.development.js 0.0% 0.0% 590.99 KB 591.01 KB 128.35 KB 128.36 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 77.42 KB 77.42 KB 23.94 KB 23.93 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 628.11 KB 628.5 KB 133.35 KB 133.43 KB FB_WWW_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js 0.0% 0.0% 605.94 KB 605.96 KB 127.41 KB 127.42 KB UMD_DEV
react-test-renderer.development.js 0.0% 0.0% 577.32 KB 577.34 KB 125.95 KB 125.96 KB NODE_DEV
react-test-renderer.production.min.js 0.0% -0.0% 76.53 KB 76.53 KB 23.71 KB 23.71 KB NODE_PROD
ReactTestRenderer-dev.js +0.1% +0.1% 600.14 KB 600.53 KB 128.74 KB 128.82 KB FB_WWW_DEV
ReactTestRenderer-dev.js 0.0% 0.0% 593.76 KB 593.77 KB 128.59 KB 128.59 KB RN_FB_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 39.17 KB 39.17 KB 9.58 KB 9.58 KB UMD_DEV

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against db1242c

@sizebot
Copy link
Copy Markdown

sizebot commented Jul 6, 2020 •
edited
Loading

Details of bundled changes.

Comparing: c7805b8...db1242c

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 881.1 KB 881.11 KB 201.83 KB 201.84 KB NODE_DEV
ReactDOMForked-prod.js 0.0% 🔺+0.1% 403.97 KB 404.08 KB 74.61 KB 74.65 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% -0.0% 137.33 KB 137.33 KB 36.48 KB 36.47 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 118.89 KB 118.89 KB 38.2 KB 38.2 KB NODE_PROD
ReactDOMForked-profiling.js 0.0% 0.0% 414.57 KB 414.76 KB 76.38 KB 76.4 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 143.45 KB 143.45 KB 36.68 KB 36.68 KB UMD_DEV
ReactDOMTesting-dev.js 0.0% 0.0% 980.9 KB 981.29 KB 219.49 KB 219.57 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 51.13 KB 51.13 KB 14.89 KB 14.89 KB NODE_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 411.95 KB 411.99 KB 77.3 KB 77.32 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 10.19 KB 10.19 KB 3.98 KB 3.98 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 925.66 KB 925.68 KB 204.25 KB 204.25 KB UMD_DEV
react-dom.profiling.min.js 0.0% -0.0% 122.67 KB 122.67 KB 40.13 KB 40.13 KB UMD_PROFILING
ReactDOMForked-dev.js 0.0% 0.0% 999.58 KB 999.97 KB 222.96 KB 223.04 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% -0.0% 122.95 KB 122.95 KB 39.42 KB 39.42 KB NODE_PROFILING
ReactDOM-dev.js 0.0% 0.0% 1013.5 KB 1013.89 KB 225.21 KB 225.28 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 408.92 KB 409.03 KB 75.6 KB 75.64 KB FB_WWW_PROD
ReactDOM-profiling.js 0.0% 0.0% 419.51 KB 419.71 KB 77.39 KB 77.4 KB FB_WWW_PROFILING
ReactDOMServer-dev.js 0.0% -0.0% 147.36 KB 147.36 KB 37.42 KB 37.42 KB FB_WWW_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js 0.0% 0.0% 252.36 KB 252.42 KB 44.7 KB 44.72 KB FB_WWW_PROD
react-art.development.js 0.0% 0.0% 667.38 KB 667.4 KB 142.07 KB 142.07 KB UMD_DEV
react-art.development.js 0.0% 0.0% 569.74 KB 569.75 KB 124.3 KB 124.3 KB NODE_DEV
ReactART-dev.js +0.1% +0.1% 638.13 KB 638.52 KB 135.4 KB 135.49 KB FB_WWW_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js 0.0% 0.0% 605.91 KB 605.93 KB 127.4 KB 127.4 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 76.69 KB 76.69 KB 23.99 KB 23.99 KB UMD_PROD
react-test-renderer.development.js 0.0% 0.0% 577.29 KB 577.31 KB 125.94 KB 125.94 KB NODE_DEV
ReactTestRenderer-dev.js +0.1% +0.1% 600.13 KB 600.52 KB 128.74 KB 128.82 KB FB_WWW_DEV
ReactTestRenderer-dev.js 0.0% 0.0% 593.74 KB 593.76 KB 128.58 KB 128.59 KB RN_FB_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 39.16 KB 39.16 KB 9.57 KB 9.57 KB UMD_DEV

Size changes (stable)

Generated by 🚫 dangerJS against db1242c

@trueadm trueadm requested a review from gaearon July 6, 2020 20:04
@trueadm trueadm force-pushed the resolve-scope-refs-in-mutation branch from 7e4bbec to a862601 Compare July 6, 2020 20:06
bvaughn
bvaughn reviewed Jul 6, 2020
View reviewed changes
Comment thread packages/react-reconciler/src/ReactFiberWorkLoop.new.js Outdated
Comment thread packages/react-reconciler/src/ReactFiberWorkLoop.new.js Outdated
Comment thread packages/react-reconciler/src/ReactFiberWorkLoop.new.js Outdated
@trueadm trueadm force-pushed the resolve-scope-refs-in-mutation branch from d12bd7c to 8f0b988 Compare July 7, 2020 11:39
bvaughn
bvaughn reviewed Jul 8, 2020
View reviewed changes
Comment thread packages/react-reconciler/src/ReactFiberWorkLoop.new.js Outdated
@trueadm trueadm force-pushed the resolve-scope-refs-in-mutation branch from 8f0b988 to db1242c Compare July 8, 2020 21:41
@trueadm trueadm merged commit 766af59 into facebook:master Jul 8, 2020
@yungsters yungsters mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaearon gaearon Awaiting requested review from gaearon

2 more reviewers

@bvaughn bvaughn bvaughn left review comments

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@trueadm @sizebot @bvaughn @sebmarkbage @facebook-github-bot