Skip to content

Add SchedulerHostConfig fork for post task#19470

Merged
rickhanlonii merged 1 commit into
facebook:masterfrom
rickhanlonii:rh-post-task
Jul 28, 2020
Merged

Add SchedulerHostConfig fork for post task#19470
rickhanlonii merged 1 commit into
facebook:masterfrom
rickhanlonii:rh-post-task

Conversation

@rickhanlonii
Copy link
Copy Markdown
Member

Overview

This PR adds a new fork for the Scheduler so we can add the postTask implementation.

@rickhanlonii rickhanlonii requested a review from acdlite July 27, 2020 21:42
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 27, 2020
@@ -0,0 +1,250 @@
/**
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copied this from the default for the initial fork

Comment thread scripts/rollup/bundles.js
},

{
bundleTypes: [FB_WWW_DEV, FB_WWW_PROD, FB_WWW_PROFILING],
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need these in the www builds.

@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2c9fcf8:

Sandbox Source
React Configuration

@sizebot
Copy link
Copy Markdown

sizebot commented Jul 27, 2020

Details of bundled changes.

Comparing: ef22aec...2c9fcf8

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler-tracing.development.js 0.0% +0.2% 8.8 KB 8.8 KB 1.78 KB 1.78 KB NODE_DEV
scheduler-unstable_mock.development.js 0.0% +0.1% 24 KB 24 KB 5.46 KB 5.46 KB UMD_DEV
scheduler-tracing.production.min.js 0.0% 🔺+1.2% 672 B 672 B 341 B 345 B NODE_PROD
scheduler-unstable_mock.production.min.js 0.0% 🔺+0.1% 4.76 KB 4.76 KB 1.99 KB 1.99 KB UMD_PROD
scheduler-tracing.profiling.min.js 0.0% +0.3% 3.2 KB 3.2 KB 951 B 954 B NODE_PROFILING
SchedulerPostTask-dev.js n/a n/a 0 B 25.7 KB 0 B 6.52 KB FB_WWW_DEV
scheduler-unstable_mock.development.js 0.0% 0.0% 22.38 KB 22.38 KB 5.34 KB 5.34 KB NODE_DEV
SchedulerPostTask-prod.js n/a n/a 0 B 12.5 KB 0 B 3.03 KB FB_WWW_PROD
scheduler-unstable_mock.production.min.js 0.0% 🔺+0.1% 4.73 KB 4.73 KB 1.9 KB 1.9 KB NODE_PROD
SchedulerPostTask-profiling.js n/a n/a 0 B 17.31 KB 0 B 3.94 KB FB_WWW_PROFILING
scheduler.development.js 0.0% 0.0% 23.26 KB 23.26 KB 6.01 KB 6.01 KB NODE_DEV
scheduler.production.min.js 0.0% 🔺+0.1% 4.94 KB 4.94 KB 1.97 KB 1.97 KB NODE_PROD

Size changes (stable)

Generated by 🚫 dangerJS against 2c9fcf8

@sizebot
Copy link
Copy Markdown

sizebot commented Jul 27, 2020

Details of bundled changes.

Comparing: ef22aec...2c9fcf8

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler-tracing.development.js 0.0% +0.2% 8.81 KB 8.81 KB 1.79 KB 1.79 KB NODE_DEV
scheduler-unstable_mock.development.js 0.0% 0.0% 24.01 KB 24.01 KB 5.46 KB 5.46 KB UMD_DEV
scheduler-tracing.production.min.js 0.0% 🔺+0.9% 685 B 685 B 349 B 352 B NODE_PROD
scheduler-unstable_mock.production.min.js 0.0% 0.0% 4.77 KB 4.77 KB 2 KB 2 KB UMD_PROD
scheduler-tracing.profiling.min.js 0.0% +0.3% 3.21 KB 3.21 KB 960 B 963 B NODE_PROFILING
SchedulerPostTask-dev.js n/a n/a 0 B 25.7 KB 0 B 6.52 KB FB_WWW_DEV
scheduler-unstable_mock.development.js 0.0% +0.1% 22.39 KB 22.39 KB 5.34 KB 5.35 KB NODE_DEV
SchedulerPostTask-prod.js n/a n/a 0 B 12.5 KB 0 B 3.03 KB FB_WWW_PROD
scheduler-unstable_mock.production.min.js 0.0% 🔺+0.2% 4.74 KB 4.74 KB 1.91 KB 1.91 KB NODE_PROD
SchedulerPostTask-profiling.js n/a n/a 0 B 17.31 KB 0 B 3.94 KB FB_WWW_PROFILING
scheduler.production.min.js 0.0% 0.0% 4.96 KB 4.96 KB 1.98 KB 1.98 KB NODE_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against 2c9fcf8

@rickhanlonii rickhanlonii merged commit 52c5146 into facebook:master Jul 28, 2020
@rickhanlonii rickhanlonii deleted the rh-post-task branch July 28, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants