Skip to content

fix(react-dom): unnecesary path on DOMEventProperties#19544

Merged
gaearon merged 1 commit intofacebook:masterfrom
DaniAcu:fix/unnecesary-path
Aug 6, 2020
Merged

fix(react-dom): unnecesary path on DOMEventProperties#19544
gaearon merged 1 commit intofacebook:masterfrom
DaniAcu:fix/unnecesary-path

Conversation

@DaniAcu
Copy link
Copy Markdown
Contributor

@DaniAcu DaniAcu commented Aug 5, 2020

Summary

I was just reading the code to understand how is working the events internally and I found that quick mistake. So I just added that change to do that all code follow same import approach. 😄

Test Plan

I think it's not necessary because it's an irrelevant change.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @DaniAcu!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Aug 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 89b2515:

Sandbox Source
React Configuration

@sizebot
Copy link
Copy Markdown

sizebot commented Aug 5, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 89b2515

@sizebot
Copy link
Copy Markdown

sizebot commented Aug 5, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 89b2515

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon merged commit 50893db into facebook:master Aug 6, 2020
@gaearon
Copy link
Copy Markdown
Collaborator

gaearon commented Aug 6, 2020

Sure, thanks.

@DaniAcu DaniAcu deleted the fix/unnecesary-path branch August 6, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants