Set up style mutation monitoring#2027
Merged
chenglou merged 1 commit intofacebook:masterfrom Apr 24, 2015
Merged
Conversation
src/browser/ui/ReactDOMComponent.js
Outdated
Collaborator
|
👍 otherwise I think. |
sebmarkbage
added
GH Review: needs-revision
and removed
GH Review: needs-revision
labels
Collaborator
|
@chenglou lgtm – can you rebase, change console.warn to warning, and remove the monitorCodeUse? |
Collaborator
|
Also make the warning message use %s instead of manual concatenation – we're aiming to have all of the warning strings be static format strings. |
Contributor
|
@chenglou ping. |
Contributor
Author
|
Sorry for the wait. Busy week. |
src/browser/ui/ReactDOMComponent.js
Outdated
Contributor
There was a problem hiding this comment.
Should use assign({}, props.style) I think? Ok, that wasn't actually part of the PR :) nvm
chenglou
force-pushed
the
warn-style-mutation
branch
from
839f586 to
3af6891
Compare
Contributor
Author
|
Edit: works now! |
Collaborator
|
@chenglou if you rebase the owner thing should work. |
This works by storing the style and its copy onto the component, and do the appropriate comparison during `_updateDOMProperties`.
chenglou
force-pushed
the
warn-style-mutation
branch
from
3af6891 to
6e992fb
Compare
Contributor
Author
|
Done! |
Contributor
Author
|
Merging then. |
chenglou
added a commit
that referenced
this pull request
Apr 24, 2015
Set up `style` mutation monitoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2008
This works by storing the style and its copy onto the component, and do the appropriate comparison during
_updateDOMProperties.