Skip to content

[DevTools] Disable sizeBot on DevTools Rull Request #21885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvaughn merged 3 commits into from
Aug 2, 2021
Merged

[DevTools] Disable sizeBot on DevTools Rull Request #21885

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a43aab9
[DevTools] Disable sizeBot on DevTools Rull Request
ryota-murakami Jul 15, 2021
e332b86
Revert "[DevTools] Disable sizeBot on DevTools Rull Request"
ryota-murakami Jul 29, 2021
078a28f
check whether devtools package file only committed
ryota-murakami Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions dangerfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,17 @@ function row(result) {
return;
}

// Disable sizeBot in a Devtools Pull Request. Because that doesn't affect production bundle size.
const commitFiles = [
...danger.git.created_files,
...danger.git.deleted_files,
...danger.git.modified_files,
];
if (
commitFiles.every(filename => filename.includes('packages/react-devtools'))
)
return;

const resultsMap = new Map();

// Find all the head (current) artifacts paths.
Expand Down