Skip to content

Automated DevTools release process #22161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvaughn merged 8 commits into from
Aug 24, 2021
Merged

Automated DevTools release process #22161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f82fcc4
Moved DevTools get-commit-list script into the scripts/devtools direc…
Aug 23, 2021
a97eed0
Add release script dependencies
Aug 24, 2021
f46d2d3
Formatted manifest JSON files
Aug 24, 2021
1d28212
Added special release script token text to CHANGELOG
Aug 24, 2021
51c5d42
DevTools release script: First iteration
Aug 24, 2021
0a8c083
Release script commits pending changes
Aug 24, 2021
41e5f77
Added build and test and publish info to release script
Aug 24, 2021
42cea6e
Format commands
Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@
"extract-errors": "yarn build --type=dev --extract-errors",
"postinstall": "node node_modules/fbjs-scripts/node/check-dev-engines.js package.json && node ./scripts/flow/createFlowConfigs.js && node ./scripts/yarn/downloadReactIsForPrettyFormat.js",
"debug-test": "yarn test --deprecated 'yarn test --debug'",
"generate-devtools-changelog": "node packages/react-devtools/get-commit-list.js",
"test": "node ./scripts/jest/jest-cli.js",
"test-stable": "node ./scripts/jest/jest-cli.js --release-channel=stable",
"test-www": "node ./scripts/jest/jest-cli.js --release-channel=www-modern",
Expand Down
27 changes: 14 additions & 13 deletions packages/react-devtools-extensions/chrome/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,48 +4,49 @@
"description": "Adds React debugging tools to the Chrome Developer Tools.",
Copy link
Contributor

@jstejada jstejada Aug 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this commit relevant to the script in some way?

Copy link
Contributor Author

@bvaughn bvaughn Aug 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I updated the manifest.json files in their own commit to match the format generated by JSON.stringify(json, null, 2) so the version update script would only affect version numbers (and no other formatting changes).

"version": "4.16.0",
"version_name": "4.16.0",

"minimum_chrome_version": "60",

"icons": {
"16": "icons/16-production.png",
"32": "icons/32-production.png",
"48": "icons/48-production.png",
"128": "icons/128-production.png"
},

"browser_action": {
"default_icon": {
"16": "icons/16-disabled.png",
"32": "icons/32-disabled.png",
"48": "icons/48-disabled.png",
"128": "icons/128-disabled.png"
},

"default_popup": "popups/disabled.html"
},

"devtools_page": "main.html",

"content_security_policy": "script-src 'self' 'unsafe-eval'; object-src 'self'",
"web_accessible_resources": [
"main.html",
"panel.html",
"build/react_devtools_backend.js",
"build/renderer.js"
],

"background": {
"scripts": ["build/background.js"],
"scripts": [
"build/background.js"
],
"persistent": false
},

"permissions": ["file:///*", "http://*/*", "https://*/*"],

"permissions": [
"file:///*",
"http://*/*",
"https://*/*"
],
"content_scripts": [
{
"matches": ["<all_urls>"],
"js": ["build/injectGlobalHook.js"],
"matches": [
"<all_urls>"
],
"js": [
"build/injectGlobalHook.js"
],
"run_at": "document_start"
}
]
Expand Down
27 changes: 14 additions & 13 deletions packages/react-devtools-extensions/edge/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,48 +4,49 @@
"description": "Adds React debugging tools to the Microsoft Edge Developer Tools.",
"version": "4.16.0",
"version_name": "4.16.0",

"minimum_chrome_version": "60",

"icons": {
"16": "icons/16-production.png",
"32": "icons/32-production.png",
"48": "icons/48-production.png",
"128": "icons/128-production.png"
},

"browser_action": {
"default_icon": {
"16": "icons/16-disabled.png",
"32": "icons/32-disabled.png",
"48": "icons/48-disabled.png",
"128": "icons/128-disabled.png"
},

"default_popup": "popups/disabled.html"
},

"devtools_page": "main.html",

"content_security_policy": "script-src 'self' 'unsafe-eval'; object-src 'self'",
"web_accessible_resources": [
"main.html",
"panel.html",
"build/react_devtools_backend.js",
"build/renderer.js"
],

"background": {
"scripts": ["build/background.js"],
"scripts": [
"build/background.js"
],
"persistent": false
},

"permissions": ["file:///*", "http://*/*", "https://*/*"],

"permissions": [
"file:///*",
"http://*/*",
"https://*/*"
],
"content_scripts": [
{
"matches": ["<all_urls>"],
"js": ["build/injectGlobalHook.js"],
"matches": [
"<all_urls>"
],
"js": [
"build/injectGlobalHook.js"
],
"run_at": "document_start"
}
]
Expand Down
28 changes: 15 additions & 13 deletions packages/react-devtools-extensions/firefox/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,53 +3,55 @@
"name": "React Developer Tools",
"description": "Adds React debugging tools to the Firefox Developer Tools.",
"version": "4.16.0",

"applications": {
"gecko": {
"id": "@react-devtools",
"strict_min_version": "55.0"
}
},

"icons": {
"16": "icons/16-production.png",
"32": "icons/32-production.png",
"48": "icons/48-production.png",
"128": "icons/128-production.png"
},

"browser_action": {
"default_icon": {
"16": "icons/16-disabled.png",
"32": "icons/32-disabled.png",
"48": "icons/48-disabled.png",
"128": "icons/128-disabled.png"
},

"default_popup": "popups/disabled.html",
"browser_style": true
},

"devtools_page": "main.html",

"content_security_policy": "script-src 'self' 'unsafe-eval' blob:; object-src 'self'",
"web_accessible_resources": [
"main.html",
"panel.html",
"build/react_devtools_backend.js",
"build/renderer.js"
],

"background": {
"scripts": ["build/background.js"]
"scripts": [
"build/background.js"
]
},

"permissions": ["file:///*", "http://*/*", "https://*/*", "clipboardWrite"],

"permissions": [
"file:///*",
"http://*/*",
"https://*/*",
"clipboardWrite"
],
"content_scripts": [
{
"matches": ["<all_urls>"],
"js": ["build/injectGlobalHook.js"],
"matches": [
"<all_urls>"
],
"js": [
"build/injectGlobalHook.js"
],
"run_at": "document_start"
}
]
Expand Down
9 changes: 1 addition & 8 deletions packages/react-devtools/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
# React DevTools changelog

<details>
<summary>
Changes that have landed in main but are not yet released.
Click to see more.
</summary>

<!-- Upcoming changes go here -->
</details>
<!-- RELEASE_SCRIPT_TOKEN -->

## 4.16.0 (August 16, 2021)
#### Features
Expand Down
66 changes: 0 additions & 66 deletions packages/react-devtools/get-commit-list.js
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions scripts/devtools/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.progress-estimator
Empty file added scripts/devtools/README.md
View file
Open in desktop
Empty file.
16 changes: 16 additions & 0 deletions scripts/devtools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"name": "react-devtools-release-script",
"version": "0.0.0",
"private": true,
"scripts": {},
"license": "MIT",
"dependencies": {
"chalk": "^2.1.0",
"child-process-promise": "^2.2.1",
"fs-extra": "^4.0.2",
"inquirer": "^8.1.2",
"progress-estimator": "^0.2.1",
"prompt-promise": "^1.0.3",
"semver": "^5.4.1"
}
}
Loading