Skip to content

Conversation

@shivamjjha
Copy link
Contributor

Summary

README grammatical & 404 links' fixes

How did you test this change?

I guess not testing required here

@facebook-github-bot
Copy link
Contributor

Hi @shivamjjha!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@sizebot
Copy link

sizebot commented Jan 26, 2022

Comparing: 13036bf...593f900

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.59 kB 129.59 kB = 41.55 kB 41.55 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 134.77 kB 134.77 kB = 43.10 kB 43.10 kB
facebook-www/ReactDOM-prod.classic.js = 428.19 kB 428.19 kB = 78.60 kB 78.60 kB
facebook-www/ReactDOM-prod.modern.js = 418.18 kB 418.18 kB = 77.17 kB 77.17 kB
facebook-www/ReactDOMForked-prod.classic.js = 428.19 kB 428.19 kB = 78.61 kB 78.61 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 593f900

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@bvaughn bvaughn merged commit 2ed58eb into facebook:main Jan 27, 2022
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
* readme: fix contributing guide links
nevilm-lt pushed a commit to nevilm-lt/react that referenced this pull request Apr 22, 2022
* readme: fix contributing guide links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants