Allow wrapping context provider in lazy #26792
Closed
+69
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is it OK to `export ContextProvider = Context.Provider;` from a `use client` file? If so, behold.
facebook-github-bot
added
CLA Signed
React Core Team
sophiebits
commented
May 8, 2023
|
|
||
| if (providerPropTypes) { | ||
| checkPropTypes(providerPropTypes, newProps, 'prop', 'Context.Provider'); | ||
| checkPropTypes(providerPropTypes, nextProps, 'prop', 'Context.Provider'); |
Collaborator
Author
There was a problem hiding this comment.
Why do we always check these in the reconciler instead of in createElement?
react/packages/react/src/ReactElementValidator.js
Lines 224 to 228 in 16d053d
Member
There was a problem hiding this comment.
IIRC, there was something subtle about either timing or default prop values? Only vaguely remember this from a comment by @sebmarkbage a while ago.
|
Comparing: 559e83a...1fb16d0 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Contributor
|
If this gets merged #27168 can likely be closed. |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it OK to
export ContextProvider = Context.Provider;from ause clientfile? If so, behold.