Remove client caching from cache() API #27977

acdlite · 2024-01-16T18:00:13Z

We haven't yet decided how we want cache to work on the client. The lifetime of the cache is more complex than on the server, where it only has to live as long as a single request.

Since it's more important to ship this on the server, we're removing the existing behavior from the client for now. On the client (i.e. not a Server Components environment) cache will have not have any caching behavior. cache(fn) will return the function as-is.

We intend to implement client caching in a future major release. In the meantime, it's only exposed as an API so that Shared Components can use per-request caching on the server without breaking on the client.

react-sizebot · 2024-01-16T18:04:17Z

Comparing: f16344e...6b66aed

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.19 kB	176.19 kB	=	54.88 kB	54.88 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.29 kB	178.29 kB	=	55.53 kB	55.53 kB
facebook-www/ReactDOM-prod.classic.js	=	571.89 kB	571.89 kB	=	100.56 kB	100.56 kB
facebook-www/ReactDOM-prod.modern.js	=	555.65 kB	555.65 kB	=	97.63 kB	97.63 kB
oss-experimental/react/umd/react.production.min.js	=	13.07 kB	12.48 kB	=	5.02 kB	4.80 kB
oss-experimental/react/umd/react.profiling.min.js	=	13.07 kB	12.48 kB	=	5.02 kB	4.80 kB
oss-experimental/react/cjs/react.production.js	=	37.96 kB	36.02 kB	=	10.26 kB	9.94 kB
oss-stable/react/umd/react.production.min.js	=	11.66 kB	11.06 kB	=	4.58 kB	4.35 kB
oss-stable/react/umd/react.profiling.min.js	=	11.66 kB	11.06 kB	=	4.58 kB	4.35 kB
oss-stable-semver/react/umd/react.production.min.js	=	11.64 kB	11.04 kB	=	4.56 kB	4.33 kB
oss-stable-semver/react/umd/react.profiling.min.js	=	11.63 kB	11.04 kB	=	4.56 kB	4.33 kB
oss-stable/react/cjs/react.production.js	=	33.34 kB	31.41 kB	=	9.28 kB	8.96 kB
oss-stable-semver/react/cjs/react.production.js	=	33.32 kB	31.38 kB	=	9.25 kB	8.93 kB
oss-experimental/react/cjs/react.production.min.js	=	9.34 kB	8.75 kB	=	3.48 kB	3.26 kB
oss-stable/react/cjs/react.production.min.js	=	7.87 kB	7.28 kB	=	3.05 kB	2.82 kB
oss-stable-semver/react/cjs/react.production.min.js	=	7.85 kB	7.26 kB	=	3.03 kB	2.79 kB
facebook-www/React-profiling.classic.js	=	19.80 kB	18.27 kB	=	5.03 kB	4.70 kB
facebook-www/React-profiling.modern.js	=	19.50 kB	17.98 kB	=	4.95 kB	4.61 kB
facebook-www/React-prod.classic.js	=	19.36 kB	17.84 kB	=	4.96 kB	4.62 kB
facebook-react-native/react/cjs/React-profiling.js	=	19.24 kB	17.71 kB	=	4.91 kB	4.58 kB
facebook-react-native/react/cjs/React-prod.js	=	19.10 kB	17.57 kB	=	4.92 kB	4.57 kB
facebook-www/React-prod.modern.js	=	19.07 kB	17.54 kB	=	4.87 kB	4.53 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
facebook-www/React-dev.classic.js	=	142.61 kB	140.39 kB	=	34.57 kB	34.21 kB
facebook-www/React-dev.modern.js	=	141.39 kB	139.17 kB	=	34.32 kB	33.97 kB
oss-experimental/react/umd/react.development.js	=	129.33 kB	127.28 kB	=	32.88 kB	32.53 kB
oss-stable/react/umd/react.development.js	=	123.61 kB	121.56 kB	=	31.64 kB	31.26 kB
oss-stable-semver/react/umd/react.development.js	=	123.59 kB	121.54 kB	=	31.61 kB	31.23 kB
facebook-react-native/react/cjs/React-dev.js	=	130.20 kB	127.98 kB	=	31.36 kB	31.00 kB
oss-experimental/react/cjs/react.development.js	=	105.98 kB	104.06 kB	=	28.12 kB	27.81 kB
oss-stable/react/cjs/react.development.js	=	100.59 kB	98.68 kB	=	26.95 kB	26.60 kB
oss-stable-semver/react/cjs/react.development.js	=	100.56 kB	98.65 kB	=	26.92 kB	26.57 kB
oss-experimental/react/umd/react.production.min.js	=	13.07 kB	12.48 kB	=	5.02 kB	4.80 kB
oss-experimental/react/umd/react.profiling.min.js	=	13.07 kB	12.48 kB	=	5.02 kB	4.80 kB
oss-experimental/react/cjs/react.production.js	=	37.96 kB	36.02 kB	=	10.26 kB	9.94 kB
oss-stable/react/umd/react.production.min.js	=	11.66 kB	11.06 kB	=	4.58 kB	4.35 kB
oss-stable/react/umd/react.profiling.min.js	=	11.66 kB	11.06 kB	=	4.58 kB	4.35 kB
oss-stable-semver/react/umd/react.production.min.js	=	11.64 kB	11.04 kB	=	4.56 kB	4.33 kB
oss-stable-semver/react/umd/react.profiling.min.js	=	11.63 kB	11.04 kB	=	4.56 kB	4.33 kB
oss-stable/react/cjs/react.production.js	=	33.34 kB	31.41 kB	=	9.28 kB	8.96 kB
oss-stable-semver/react/cjs/react.production.js	=	33.32 kB	31.38 kB	=	9.25 kB	8.93 kB
oss-experimental/react/cjs/react.production.min.js	=	9.34 kB	8.75 kB	=	3.48 kB	3.26 kB
oss-stable/react/cjs/react.production.min.js	=	7.87 kB	7.28 kB	=	3.05 kB	2.82 kB
oss-stable-semver/react/cjs/react.production.min.js	=	7.85 kB	7.26 kB	=	3.03 kB	2.79 kB
facebook-www/React-profiling.classic.js	=	19.80 kB	18.27 kB	=	5.03 kB	4.70 kB
facebook-www/React-profiling.modern.js	=	19.50 kB	17.98 kB	=	4.95 kB	4.61 kB
facebook-www/React-prod.classic.js	=	19.36 kB	17.84 kB	=	4.96 kB	4.62 kB
facebook-react-native/react/cjs/React-profiling.js	=	19.24 kB	17.71 kB	=	4.91 kB	4.58 kB
facebook-react-native/react/cjs/React-prod.js	=	19.10 kB	17.57 kB	=	4.92 kB	4.57 kB
facebook-www/React-prod.modern.js	=	19.07 kB	17.54 kB	=	4.87 kB	4.53 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against 6b66aed

cache() on the client is not yet stable. It's only stable in Server Components. This rewrites the tests to use the Flight renderer instead of React Noop. I also split the cache() tests into a separate module from the tests for the <Cache> element, which is a different (experimental) feature.

Because we haven't decided on the client caching semantics of cache(), we're going to remove the behavior for now and add it back later. So we need to rewrite these client tests to not depend on cache(). This essentially reverts the test suite back to what it was before facebook#25506. There were also some tests in the ReactUse-test module that depended on cache() too, which I've also updated.

We haven't yet decided how we want `cache` to work on the client. The lifetime of the cache is more complex than on the server, where it only has to live as long as a single request. Since it's more important to ship this on the server, we're removing the existing behavior from the client for now. On the client (i.e. not a Server Components environment) `cache` will have not have any caching behavior. The rest of the behavior is the same as the server implementation — it returns a new reference, extra properties like `displayName` are not preserved, the length of the new function is 0, etc. That way apps can't accidentally depend on those details. We intend to implement client caching in a future major release. In the meantime, it's only exposed as an API so that Shared Components can use per-request caching on the server without breaking on the client.

We haven't yet decided how we want `cache` to work on the client. The lifetime of the cache is more complex than on the server, where it only has to live as long as a single request. Since it's more important to ship this on the server, we're removing the existing behavior from the client for now. On the client (i.e. not a Server Components environment) `cache` will have not have any caching behavior. `cache(fn)` will return the function as-is. We intend to implement client caching in a future major release. In the meantime, it's only exposed as an API so that Shared Components can use per-request caching on the server without breaking on the client. DiffTrain build for [5c60736](5c60736)

We haven't yet decided how we want `cache` to work on the client. The lifetime of the cache is more complex than on the server, where it only has to live as long as a single request. Since it's more important to ship this on the server, we're removing the existing behavior from the client for now. On the client (i.e. not a Server Components environment) `cache` will have not have any caching behavior. `cache(fn)` will return the function as-is. We intend to implement client caching in a future major release. In the meantime, it's only exposed as an API so that Shared Components can use per-request caching on the server without breaking on the client.

We haven't yet decided how we want `cache` to work on the client. The lifetime of the cache is more complex than on the server, where it only has to live as long as a single request. Since it's more important to ship this on the server, we're removing the existing behavior from the client for now. On the client (i.e. not a Server Components environment) `cache` will have not have any caching behavior. `cache(fn)` will return the function as-is. We intend to implement client caching in a future major release. In the meantime, it's only exposed as an API so that Shared Components can use per-request caching on the server without breaking on the client. DiffTrain build for commit 5c60736.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 16, 2024

acdlite changed the title ~~Revert client cache~~ Remove client caching from cache() API Jan 16, 2024

acdlite force-pushed the revert-client-cache branch 2 times, most recently from 0438f3b to 16ab9af Compare January 16, 2024 19:29

acdlite marked this pull request as ready for review January 16, 2024 19:30

acdlite force-pushed the revert-client-cache branch from 16ab9af to ef98a2e Compare January 16, 2024 19:34

gnoff approved these changes Jan 16, 2024

View reviewed changes

acdlite added 3 commits January 16, 2024 20:20

acdlite force-pushed the revert-client-cache branch from ef98a2e to 6b66aed Compare January 17, 2024 01:20

acdlite merged commit 5c60736 into facebook:main Jan 17, 2024
35 of 36 checks passed

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

unstubbable mentioned this pull request May 11, 2024

Use a simple replacement for React.cache unstubbable/mfng#72

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove client caching from cache() API #27977

Remove client caching from cache() API #27977

acdlite commented Jan 16, 2024 •

edited

react-sizebot commented Jan 16, 2024 •

edited

Remove client caching from cache() API #27977

Remove client caching from cache() API #27977

Conversation

acdlite commented Jan 16, 2024 • edited

react-sizebot commented Jan 16, 2024 • edited

Critical size changes

Significant size changes

acdlite commented Jan 16, 2024 •

edited

react-sizebot commented Jan 16, 2024 •

edited