Convert ReactMount to createRoot #28075

rickhanlonii · 2024-01-24T17:41:37Z

To convert this file, I started replacing all the calls in line, and quickly realized that we already have most of these tests covered in other files. So I found the test that we didn't already have for create/hydrateRoot and added them, then renamed ReactMount to ReactLegacyMount.

rickhanlonii · 2024-01-24T17:42:50Z

packages/react-dom/src/__tests__/ReactDOMRoot-test.js

@@ -175,27 +175,6 @@ describe('ReactDOMRoot', () => {
    );
  });

-  it('clears existing children with legacy API', async () => {


I also moved any legacy tests in this file (which @eps1lon found), and moved them into ReactLegacyRoot.

react-sizebot · 2024-01-24T17:45:27Z

Comparing: ee1eb48...436c433

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.24 kB	176.24 kB	=	54.88 kB	54.88 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.34 kB	178.34 kB	=	55.53 kB	55.53 kB
facebook-www/ReactDOM-prod.classic.js	=	571.94 kB	571.94 kB	=	100.56 kB	100.56 kB
facebook-www/ReactDOM-prod.modern.js	=	555.70 kB	555.70 kB	=	97.62 kB	97.62 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against 436c433

jackpope

Walked through changes with Rick. Looking good

To convert this file, I started replacing all the calls in line, and quickly realized that we already have most of these tests covered in other files. So I found the test that we didn't already have for `create/hydrateRoot` and added them, then renamed `ReactMount` to `ReactLegacyMount`.

To convert this file, I started replacing all the calls in line, and quickly realized that we already have most of these tests covered in other files. So I found the test that we didn't already have for `create/hydrateRoot` and added them, then renamed `ReactMount` to `ReactLegacyMount`. DiffTrain build for commit 5420c4e.

Convert ReactMount to createRoot

d8fbb95

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 24, 2024

rickhanlonii commented Jan 24, 2024

View reviewed changes

rickhanlonii added 3 commits January 24, 2024 12:55

Convert ReactMount to createRoot

764effb

Fix tests

5119374

No fallback to client render in www

436c433

rickhanlonii marked this pull request as ready for review January 24, 2024 19:47

eps1lon approved these changes Jan 24, 2024

View reviewed changes

jackpope approved these changes Jan 24, 2024

View reviewed changes

rickhanlonii merged commit 5420c4e into facebook:main Jan 25, 2024
36 checks passed

rickhanlonii deleted the rh/test-mount branch January 25, 2024 04:58

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert ReactMount to createRoot #28075

Convert ReactMount to createRoot #28075

rickhanlonii commented Jan 24, 2024

rickhanlonii Jan 24, 2024

react-sizebot commented Jan 24, 2024 •

edited

jackpope left a comment

Convert ReactMount to createRoot #28075

Convert ReactMount to createRoot #28075

Conversation

rickhanlonii commented Jan 24, 2024

rickhanlonii Jan 24, 2024

Choose a reason for hiding this comment

react-sizebot commented Jan 24, 2024 • edited

Critical size changes

Significant size changes

jackpope left a comment

Choose a reason for hiding this comment

react-sizebot commented Jan 24, 2024 •

edited