Add ReactDOMClient to ServerIntegrationElements #28134

rickhanlonii · 2024-01-27T23:59:31Z

Overview

Branched off #28130

Failing Fixed by @eps1lon

The tests are currently failing because of two tests covering special characters. I've tried a few ways to fix, but I'm stuck and will need some help understanding why they fail and how to fix.

react-sizebot · 2024-01-28T00:01:12Z

Comparing: 9aef5d2...01b7240

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.59 kB	176.59 kB	=	55.01 kB	55.01 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.69 kB	178.69 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	573.52 kB	573.52 kB	=	100.99 kB	100.99 kB
facebook-www/ReactDOM-prod.modern.js	=	557.29 kB	557.29 kB	=	98.07 kB	98.07 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against 01b7240

eps1lon · 2024-01-28T11:13:25Z

packages/react-dom/src/__tests__/ReactDOMServerIntegrationElements-test.js

            // Null character is ignored.
            expectNode(e.childNodes[0], TEXT_NODE_TYPE, 'foo\nbar');
            expectNode(e.childNodes[2], TEXT_NODE_TYPE, '\nbaz\nqux');
          } else if (render === clientRenderOnServerString) {
            // We have three nodes because there is a comment between them.
            expect(e.childNodes.length).toBe(3);
-            // Hydration uses JS value with CR and null character.
+            // Hydration without enableClientRenderFallbackOnTextMismatch uses JS value with CR and null character.


Hydrating with the new root without enableClientRenderFallbackOnTextMismatch (www) is like old root i.e. replaces server HTML with client side rendered CR.
Hydrating with the new root with enableClientRenderFallbackOnTextMismatch is keeping the server HTML.

Looks like not patching up the server HTML here was intentionally added in #26391

Nice explanation, thanks for the fix!

…smatch

@eps1lon

## Overview Branched off #28130 ## ~Failing~ Fixed by @eps1lon The tests are currently failing because of two tests covering special characters. I've tried a few ways to fix, but I'm stuck and will need some help understanding why they fail and how to fix. --------- Co-authored-by: Sebastian Silbermann <sebastian.silbermann@klarna.com>

@eps1lon

## Overview Branched off facebook#28130 ## ~Failing~ Fixed by @eps1lon The tests are currently failing because of two tests covering special characters. I've tried a few ways to fix, but I'm stuck and will need some help understanding why they fail and how to fix. --------- Co-authored-by: Sebastian Silbermann <sebastian.silbermann@klarna.com>

@eps1lon

## Overview Branched off #28130 ## ~Failing~ Fixed by @eps1lon The tests are currently failing because of two tests covering special characters. I've tried a few ways to fix, but I'm stuck and will need some help understanding why they fail and how to fix. --------- Co-authored-by: Sebastian Silbermann <sebastian.silbermann@klarna.com> DiffTrain build for commit c0d9277.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 27, 2024

rickhanlonii force-pushed the rh/server-test-utils-elements branch from 5a8658b to 9fed422 Compare January 28, 2024 00:01

eps1lon reviewed Jan 28, 2024

View reviewed changes

rickhanlonii marked this pull request as ready for review January 28, 2024 21:10

eps1lon approved these changes Jan 29, 2024

View reviewed changes

rickhanlonii changed the title ~~[Failing] Add ReactDOMClient to ServerIntegrationElements~~ Add ReactDOMClient to ServerIntegrationElements Jan 29, 2024

Add ReactDOMClient to ServerIntegrationTestUtils

e204d76

rickhanlonii force-pushed the rh/server-test-utils branch from 233b65d to e204d76 Compare February 1, 2024 20:53

rickhanlonii and others added 3 commits February 1, 2024 16:03

Add ReactDOMClient to ServerIntegrationElements

5f9330f

Hydration keeps LF from server HTML

d4a608b

Change in behavior is gated behind enableClientRenderFallbackOnTextMi…

01b7240

…smatch

rickhanlonii force-pushed the rh/server-test-utils-elements branch from 1b4b4dc to 01b7240 Compare February 1, 2024 21:05

Base automatically changed from rh/server-test-utils to main February 1, 2024 23:27

rickhanlonii merged commit c0d9277 into main Feb 1, 2024
36 checks passed

rickhanlonii deleted the rh/server-test-utils-elements branch February 1, 2024 23:32

gnoff mentioned this pull request Feb 5, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ReactDOMClient to ServerIntegrationElements #28134

Add ReactDOMClient to ServerIntegrationElements #28134

rickhanlonii commented Jan 27, 2024 •

edited

react-sizebot commented Jan 28, 2024 •

edited

eps1lon Jan 28, 2024

rickhanlonii Jan 28, 2024

Add ReactDOMClient to ServerIntegrationElements #28134

Add ReactDOMClient to ServerIntegrationElements #28134

Conversation

rickhanlonii commented Jan 27, 2024 • edited

Overview

Failing Fixed by @eps1lon

react-sizebot commented Jan 28, 2024 • edited

Critical size changes

Significant size changes

eps1lon Jan 28, 2024

Choose a reason for hiding this comment

rickhanlonii Jan 28, 2024

Choose a reason for hiding this comment

rickhanlonii commented Jan 27, 2024 •

edited

react-sizebot commented Jan 28, 2024 •

edited