Convert DOMPluginEventSystem to createRoot #28139

eps1lon · 2024-01-28T13:03:45Z

No description provided.

eps1lon · 2024-01-28T13:04:29Z

packages/react-dom/src/events/__tests__/DOMPluginEventSystem-test.internal.js

@@ -389,7 +420,7 @@ describe('DOMPluginEventSystem', () => {
          expect(log[9]).toEqual(['bubble', buttonElement]);
        });

-        it('handle propagation of click events between disjointed comment roots', () => {
+        it('handle propagation of click events between disjointed legacy comment roots', () => {


comment nodes are not supported by the new root so these tests need to be gated.

react-sizebot · 2024-01-28T13:07:25Z

Comparing: e2b93af...31dbbf8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.59 kB	176.59 kB	=	55.01 kB	55.01 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.69 kB	178.69 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	573.52 kB	573.52 kB	=	100.99 kB	100.99 kB
facebook-www/ReactDOM-prod.modern.js	=	557.29 kB	557.29 kB	=	98.07 kB	98.07 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against 31dbbf8

Follow-up to #28139 (comment) I mistakenly kept the tests using comment nodes as containers as legacy tests. It's not that comments nodes aren't allowed in createRoot entirely. Only behind `disableCommentsAsDOMContainers`. We already had one test following that pattern so I just applied the same pattern to the other tests for consistency. Now `DOMPluginEventSystem` no longer uses any legacy roots.

Follow-up to #28139 (comment) I mistakenly kept the tests using comment nodes as containers as legacy tests. It's not that comments nodes aren't allowed in createRoot entirely. Only behind `disableCommentsAsDOMContainers`. We already had one test following that pattern so I just applied the same pattern to the other tests for consistency. Now `DOMPluginEventSystem` no longer uses any legacy roots.

Follow-up to facebook#28139 (comment) I mistakenly kept the tests using comment nodes as containers as legacy tests. It's not that comments nodes aren't allowed in createRoot entirely. Only behind `disableCommentsAsDOMContainers`. We already had one test following that pattern so I just applied the same pattern to the other tests for consistency. Now `DOMPluginEventSystem` no longer uses any legacy roots.

DiffTrain build for commit 00d42ac.

Convert DOMPluginEventSystem to createRoot

31dbbf8

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 28, 2024

eps1lon commented Jan 28, 2024

View reviewed changes

eps1lon marked this pull request as ready for review January 28, 2024 13:25

rickhanlonii approved these changes Jan 28, 2024

View reviewed changes

eps1lon merged commit 00d42ac into facebook:main Jan 29, 2024
36 checks passed

eps1lon deleted the test/create-root/DOMPluginEventSystem branch January 29, 2024 08:12

eps1lon mentioned this pull request Jan 29, 2024

Complete DOMPluginEventSystem migration to createRoot #28148

Merged

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

gaearon pushed a commit that referenced this pull request Feb 3, 2024

Convert DOMPluginEventSystem to createRoot (#28139)

758ce37

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

Convert DOMPluginEventSystem to createRoot (facebook#28139)

c7ea284

bigfootjon pushed a commit that referenced this pull request Apr 18, 2024

Convert DOMPluginEventSystem to createRoot (#28139)

4f379ca

DiffTrain build for commit 00d42ac.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert DOMPluginEventSystem to createRoot #28139

Convert DOMPluginEventSystem to createRoot #28139

eps1lon commented Jan 28, 2024

eps1lon Jan 28, 2024 •

edited

react-sizebot commented Jan 28, 2024

Convert DOMPluginEventSystem to createRoot #28139

Convert DOMPluginEventSystem to createRoot #28139

Conversation

eps1lon commented Jan 28, 2024

eps1lon Jan 28, 2024 • edited

Choose a reason for hiding this comment

react-sizebot commented Jan 28, 2024

Critical size changes

Significant size changes

eps1lon Jan 28, 2024 •

edited