Convert SyntheticWheelEvent-test.js to createRoot #28103

mattcarrollcode · 2024-01-26T05:18:05Z

No description provided.

react-sizebot · 2024-01-26T05:43:26Z

Comparing: 9bad8ed...5970396

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.64 kB	176.64 kB	=	55.01 kB	55.01 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.74 kB	178.74 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	573.66 kB	573.66 kB	=	101.02 kB	101.02 kB
facebook-www/ReactDOM-prod.modern.js	=	557.42 kB	557.42 kB	=	98.10 kB	98.10 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against 5970396

rickhanlonii

Looks good!

The test failure looks like an unrelated flaky test, I re-ran the job.

rickhanlonii · 2024-01-26T05:46:20Z

packages/react-dom/src/events/__tests__/SyntheticWheelEvent-test.js

@@ -83,7 +92,7 @@ describe('SyntheticWheelEvent', () => {
    expect(events[1].deltaY).toBe(-50);
  });

-  it('should be able to `preventDefault` and `stopPropagation`', () => {
+  it('should be able to `preventDefault` and `stopPropagation`', async () => {


Can add an expect.assertions(3) to the end of this test

Shouldn't the expected number of assertions be 5? 2x for each dispatchEvent call (4 total) and one expect events to be "2".

Yeah I counted wrong

DiffTrain build for commit fbb2106.

Migrate SyntheticWheelEvent-test.js from ReactDOM.render to createRoot

4b1e8ba

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 26, 2024

rickhanlonii approved these changes Jan 26, 2024

View reviewed changes

mattcarrollcode added 2 commits January 25, 2024 23:50

Add expected number of assertions

7c1b083

Fix lint issue

5970396

rickhanlonii merged commit fbb2106 into facebook:main Jan 26, 2024
21 of 23 checks passed

mattcarrollcode deleted the syn-wheel-event-test branch January 26, 2024 16:47

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

Convert SyntheticWheelEvent-test.js to createRoot (facebook#28103)

806c62c

bigfootjon pushed a commit that referenced this pull request Apr 18, 2024

Convert SyntheticWheelEvent-test.js to createRoot (#28103)

88bb49d

DiffTrain build for commit fbb2106.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert SyntheticWheelEvent-test.js to createRoot #28103

Convert SyntheticWheelEvent-test.js to createRoot #28103

mattcarrollcode commented Jan 26, 2024

react-sizebot commented Jan 26, 2024 •

edited

rickhanlonii left a comment

rickhanlonii Jan 26, 2024

mattcarrollcode Jan 26, 2024

rickhanlonii Jan 26, 2024

Convert SyntheticWheelEvent-test.js to createRoot #28103

Convert SyntheticWheelEvent-test.js to createRoot #28103

Conversation

mattcarrollcode commented Jan 26, 2024

react-sizebot commented Jan 26, 2024 • edited

Critical size changes

Significant size changes

rickhanlonii left a comment

Choose a reason for hiding this comment

rickhanlonii Jan 26, 2024

Choose a reason for hiding this comment

mattcarrollcode Jan 26, 2024

Choose a reason for hiding this comment

rickhanlonii Jan 26, 2024

Choose a reason for hiding this comment

react-sizebot commented Jan 26, 2024 •

edited