Convert ReactDOMSelect to createRoot #28142

eps1lon · 2024-01-28T14:25:42Z

No description provided.

eps1lon · 2024-01-28T14:28:34Z

packages/react-dom/src/__tests__/ReactDOMSelect-test.js


    expect(node.options[0].selected).toBe(false); // a
    expect(node.options[1].selected).toBe(true); // b
    expect(node.options[2].selected).toBe(false); // c
  });

-  it('should allow controlling `value` in a nested render', () => {
+  it('should allow controlling `value` in a nested legacy render', async () => {


This test calls render using a container that is already owned by the parent root. This pattern is no longer supported with createRoot and would error with

Warning: You are calling ReactDOMClient.createRoot() on a container that has already been passed to createRoot() before. Instead, call root.render() on the existing root instead if you want to update it.

Seems to me this case is no longer supported with the new root.

react-sizebot · 2024-01-28T14:30:12Z

Comparing: e2b93af...71b15ff

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.59 kB	176.59 kB	=	55.01 kB	55.01 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.69 kB	178.69 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	573.52 kB	573.52 kB	=	100.99 kB	100.99 kB
facebook-www/ReactDOM-prod.modern.js	=	557.29 kB	557.29 kB	=	98.07 kB	98.07 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against 71b15ff

DiffTrain build for commit 1c8901f.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 28, 2024

Convert ReactDOMSelect to createRoot

71b15ff

eps1lon force-pushed the test/create-root/ReactDOMSelect branch from c56f18b to 71b15ff Compare January 28, 2024 14:26

eps1lon commented Jan 28, 2024

View reviewed changes

eps1lon marked this pull request as ready for review January 28, 2024 15:55

rickhanlonii approved these changes Jan 28, 2024

View reviewed changes

eps1lon merged commit 1c8901f into facebook:main Jan 29, 2024
36 checks passed

eps1lon deleted the test/create-root/ReactDOMSelect branch January 29, 2024 08:10

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

gaearon pushed a commit that referenced this pull request Feb 3, 2024

Convert ReactDOMSelect to createRoot (#28142)

12148cc

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

Convert ReactDOMSelect to createRoot (facebook#28142)

d49f12a

bigfootjon pushed a commit that referenced this pull request Apr 18, 2024

Convert ReactDOMSelect to createRoot (#28142)

9801e9a

DiffTrain build for commit 1c8901f.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert ReactDOMSelect to createRoot #28142

Convert ReactDOMSelect to createRoot #28142

eps1lon commented Jan 28, 2024

eps1lon Jan 28, 2024

react-sizebot commented Jan 28, 2024

Convert ReactDOMSelect to createRoot #28142

Convert ReactDOMSelect to createRoot #28142

Conversation

eps1lon commented Jan 28, 2024

eps1lon Jan 28, 2024

Choose a reason for hiding this comment

react-sizebot commented Jan 28, 2024

Critical size changes

Significant size changes