convert ReactElementClone-test from renderIntoDocument #28193

noahlemen · 2024-02-01T18:42:49Z

Summary

migrates to createRoot – renderIntoDocument uses ReactDOM.render

How did you test this change?

yarn test ReactElementClone

react-sizebot · 2024-02-01T18:44:48Z

Comparing: 554fc49...ecf8d31

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.57 kB	176.57 kB	=	55.00 kB	55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.67 kB	178.67 kB	=	55.63 kB	55.63 kB
facebook-www/ReactDOM-prod.classic.js	=	573.50 kB	573.50 kB	=	100.98 kB	100.98 kB
facebook-www/ReactDOM-prod.modern.js	=	557.26 kB	557.26 kB	=	98.06 kB	98.06 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against ecf8d31

## Summary migrates to createRoot – renderIntoDocument uses ReactDOM.render ## How did you test this change? yarn test ReactElementClone

## Summary migrates to createRoot – renderIntoDocument uses ReactDOM.render ## How did you test this change? yarn test ReactElementClone

## Summary migrates to createRoot – renderIntoDocument uses ReactDOM.render ## How did you test this change? yarn test ReactElementClone DiffTrain build for commit 94259cd.

convert ReactElementClone-test from renderIntoDocument

1402a52

noahlemen requested review from kassens and rickhanlonii February 1, 2024 18:42

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 1, 2024

noahlemen added 2 commits February 1, 2024 13:47

remove unused ReactTestUtils

0ba4287

lint fix

ecf8d31

eps1lon approved these changes Feb 1, 2024

View reviewed changes

noahlemen merged commit 94259cd into main Feb 1, 2024
36 checks passed

noahlemen deleted the reactelementclone-test-remove-renderintodoc branch February 1, 2024 19:45

gaearon pushed a commit that referenced this pull request Feb 3, 2024

convert ReactElementClone-test from renderIntoDocument (#28193)

3af70fe

## Summary migrates to createRoot – renderIntoDocument uses ReactDOM.render ## How did you test this change? yarn test ReactElementClone

gnoff mentioned this pull request Feb 5, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

convert ReactElementClone-test from renderIntoDocument #28193

convert ReactElementClone-test from renderIntoDocument #28193

noahlemen commented Feb 1, 2024

react-sizebot commented Feb 1, 2024 •

edited

convert ReactElementClone-test from renderIntoDocument #28193

convert ReactElementClone-test from renderIntoDocument #28193

Conversation

noahlemen commented Feb 1, 2024

Summary

How did you test this change?

react-sizebot commented Feb 1, 2024 • edited

Critical size changes

Significant size changes

react-sizebot commented Feb 1, 2024 •

edited