Convert ReactFresh to createRoot #28170

eps1lon · 2024-01-31T20:00:57Z

No description provided.

react-sizebot · 2024-01-31T20:04:58Z

Comparing: 38ef167...6aea7f8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.57 kB	176.57 kB	=	55.00 kB	55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.69 kB	178.69 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	591.32 kB	591.32 kB	=	104.34 kB	104.34 kB
facebook-www/ReactDOM-prod.modern.js	=	575.08 kB	575.08 kB	=	101.43 kB	101.43 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Generated by 🚫 dangerJS against 6aea7f8

eps1lon · 2024-02-02T18:30:35Z

packages/react-refresh/src/__tests__/ReactFresh-test.js

      expect(container.childNodes.length).toBe(2);
      expect(container.childNodes[0]).toBe(primaryChild);
      expect(container.childNodes[1]).toBe(fallbackChild);
      expect(primaryChild.textContent).toBe('Content 1');
-      expect(primaryChild.style.color).toBe('red');
+      expect(primaryChild.style.color).toBe('green');


This test is no longer passing. Seems like it really can't patch both trees anymore. @gaearon Could you take a look if there's a legit bug or something we just can't test in new roots anymore.

I'm not sure but I suspect maybe we don't bother re-rendering the invisible component because it's offscreen? I'd rephrase the test so that it doesn't assert that it has to be green or red here — I think the important part is that by the time we unsuspend, the color of the content is up-to-date. Until then, I think it doesn't really matter because it's unobservable.

Test now reads "only patches the fallback tree while suspended"

eps1lon · 2024-02-02T19:11:01Z

packages/react-refresh/src/__tests__/ReactFresh-test.js

        }
      }
    }
-  });
+  }, 10000);


This test consistently timed out with the default timeout of 5s in CI: https://app.circleci.com/pipelines/github/facebook/react/49942/workflows/4d2a2a4a-54ee-4ed3-9e1d-80c7bb4b0e28/jobs/767976

DiffTrain build for commit 93a5f40.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 31, 2024

eps1lon force-pushed the test/create-root/ReactFresh branch 2 times, most recently from 4c64ec1 to 916fd9f Compare January 31, 2024 21:47

eps1lon marked this pull request as ready for review February 1, 2024 08:12

Sebastian Silbermann added 4 commits February 2, 2024 19:29

Convert ReactFresh to createRoot

cce00bc

Amend assertions

39f95f4

Silly mistake

c52fc26

Don't need to wrap performReactRefresh in act

6462aaf

eps1lon force-pushed the test/create-root/ReactFresh branch from 89e9b6c to 6462aaf Compare February 2, 2024 18:29

eps1lon commented Feb 2, 2024

View reviewed changes

Sebastian Silbermann added 2 commits February 2, 2024 19:48

Update test name to reflect new behavior

caac078

Increase timeout for slow tests

6aea7f8

eps1lon commented Feb 2, 2024

View reviewed changes

gaearon approved these changes Feb 3, 2024

View reviewed changes

eps1lon merged commit 93a5f40 into facebook:main Feb 4, 2024
36 checks passed

eps1lon deleted the test/create-root/ReactFresh branch February 4, 2024 10:29

gnoff mentioned this pull request Feb 5, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

Convert ReactFresh to createRoot (facebook#28170)

3007450

bigfootjon pushed a commit that referenced this pull request Apr 18, 2024

Convert ReactFresh to createRoot (#28170)

5a401e5

DiffTrain build for commit 93a5f40.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert ReactFresh to createRoot #28170

Convert ReactFresh to createRoot #28170

eps1lon commented Jan 31, 2024

react-sizebot commented Jan 31, 2024 •

edited

eps1lon Feb 2, 2024

gaearon Feb 3, 2024 •

edited

eps1lon Feb 4, 2024

eps1lon Feb 2, 2024 •

edited

Convert ReactFresh to createRoot #28170

Convert ReactFresh to createRoot #28170

Conversation

eps1lon commented Jan 31, 2024

react-sizebot commented Jan 31, 2024 • edited

Critical size changes

Significant size changes

eps1lon Feb 2, 2024

Choose a reason for hiding this comment

gaearon Feb 3, 2024 • edited

Choose a reason for hiding this comment

eps1lon Feb 4, 2024

Choose a reason for hiding this comment

eps1lon Feb 2, 2024 • edited

Choose a reason for hiding this comment

react-sizebot commented Jan 31, 2024 •

edited

gaearon Feb 3, 2024 •

edited

eps1lon Feb 2, 2024 •

edited