Skip to content

Add displayName to nested render warnings [#1726] #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sophiebits merged 2 commits into from
Mar 10, 2015
Merged

Add displayName to nested render warnings [#1726] #2946

sophiebits merged 2 commits into from
Mar 10, 2015

Conversation

@benmoss
Copy link
Contributor

@benmoss benmoss commented Jan 26, 2015

Trying to fix #1726

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 26, 2015

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 26, 2015

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

zpao
zpao reviewed Feb 2, 2015
View reviewed changes
src/core/__tests__/ReactCompositeComponent-test.js Outdated
Copy link
Member

@zpao zpao Feb 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be picking up Outer as the display name (the transform adds it).

@benmoss benmoss force-pushed the nested-render-warning branch 2 times, most recently from 46478e0 to bf3982f Compare February 2, 2015 23:05
@benmoss benmoss force-pushed the nested-render-warning branch from bf3982f to ba55716 Compare February 2, 2015 23:05
@benmoss
Copy link
Contributor Author

benmoss commented Feb 2, 2015

Apologies for the bad PR, I didn't fully understand the context. Hopefully this fixes those issues you caught.

@sophiebits
Copy link
Collaborator

sophiebits commented Feb 26, 2015

This looks good – will merge after 0.13.

sophiebits added a commit that referenced this pull request Mar 10, 2015
@sophiebits
Merge pull request #2946 from benmoss/nested-render-warning
f77de57 
Add displayName to nested render warnings [#1726]
@sophiebits sophiebits merged commit f77de57 into facebook:master Mar 10, 2015
@benmoss benmoss deleted the nested-render-warning branch March 11, 2015 01:19
josephsavona pushed a commit that referenced this pull request May 15, 2024
@kassens
CI: fix Compiler TypeScript workflow (#2946)
257f22a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add displayName to nested render warning

4 participants

@benmoss @facebook-github-bot @sophiebits @zpao