Current behavior for Effect behavior in StrictMode when reordering #29595
+163
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
eps1lon
force-pushed
the
strict-effects-bad-invocations
branch
3 times, most recently
from
4485e6b to
3b1f29b
Compare
|
Comparing: ea6e059...f94b10f Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
eps1lon
force-pushed
the
strict-effects-bad-invocations
branch
from
3b1f29b to
f94b10f
Compare
eps1lon
commented
May 27, 2024
Comment on lines
+1116
to
+1117
| "passive destroy second: 1", | ||
| "passive create second: 1", |
Collaborator
Author
There was a problem hiding this comment.
Just double invoking the second one.
rachitiitr
reviewed
May 30, 2024
| } | ||
| }); | ||
|
|
||
| it('effect invovation after key swap', async () => { |
|
Do we want to rephrase the PR title? To |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test for current behavior experienced in #29585.
How did you test this change?
yarn test --watch packages/react-reconciler/src/__tests__/StrictEffectsMode-test.js -t "effect invovation after key swap"