Independent re-renders from UNSAFE_componentWillReceiveProps cause maximum update depth error #30175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ximum update depth error In this added test case, each render causes a second pass render follow up, but it always settles. Repeating this sufficiently often triggers the "Maximum update depth exceeded." error because the `nestedUpdateCount` in `ReactFiberWorkLoop.js` doesn't reset.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this added test case, each render causes a second pass render follow up, but it always settles.
Repeating this sufficiently often triggers the "Maximum update depth exceeded." error because the
nestedUpdateCountinReactFiberWorkLoop.jsdoesn't reset.