Warn if a non-object value is used in ReactFragment.create #3107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/addons/ReactFragment.js
Outdated
Collaborator
There was a problem hiding this comment.
These arguments look a little mixed up. Shouldn't the format string be the second arg?
Contributor
Author
There was a problem hiding this comment.
Nice catch. Probably merge issue. I had the conditional inline first and then needed to return early for this conditional so I broke it out.
I made this mistake while upgrading a few callers. I'm leaving this as warning so that it is always safe to wrap any existing child in React.addons.createFragment without breaking prod. This makes upgrading easier.
sebmarkbage
force-pushed
the
fragments
branch
from
994b7fe to
093ab00
Compare
Member
There was a problem hiding this comment.
Do we want to be stricter and also warn for arrays?
Contributor
Author
There was a problem hiding this comment.
What about iterables? Maps?
Member
There was a problem hiding this comment.
Meh, make it as strict as you want.
sebmarkbage
added a commit
that referenced
this pull request
Feb 11, 2015
Warn if a non-object value is used in ReactFragment.create
Contributor
Author
|
We might want to disallow Maps without a ReactFragment wrapper. Will revisit the constraints here after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this mistake while upgrading a few callers.
I'm leaving this as warning so that it is always safe to wrap any existing
child in React.addons.createFragment without breaking prod.
This makes upgrading easier.