Skip to content

rename Id suffix to ID to apply naming conventions #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zpao merged 2 commits into from
Feb 11, 2015
Merged

rename Id suffix to ID to apply naming conventions #3114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58d7051
rename `Id` suffix to `ID` to apply naming conventions
chicoxyzzy Feb 10, 2015
fbe88c7
fix Microdata properties' commentaries
chicoxyzzy Feb 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/browser/ui/dom/HTMLDOMPropertyConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ var HTMLDOMPropertyConfig = {
// keyboard hints.
autoCapitalize: null,
autoCorrect: null,
// itemProp, itemScope, itemType, itemType, itemId are for
// itemProp, itemScope, itemType are for
// Microdata support. See http://schema.org/docs/gs.html
itemProp: MUST_USE_ATTRIBUTE,
itemScope: MUST_USE_ATTRIBUTE | HAS_BOOLEAN_VALUE,
Expand Down
8 changes: 4 additions & 4 deletions src/core/ReactEmptyComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ var invariant = require('invariant');
var component;
// This registry keeps track of the React IDs of the components that rendered to
// `null` (in reality a placeholder such as `noscript`)
var nullComponentIdsRegistry = {};
var nullComponentIDsRegistry = {};

var ReactEmptyComponentInjection = {
injectEmptyComponent: function(emptyComponent) {
Expand Down Expand Up @@ -63,23 +63,23 @@ var emptyElement = ReactElement.createElement(ReactEmptyComponentType);
* @param {string} id Component's `_rootNodeID`.
*/
function registerNullComponentID(id) {
nullComponentIdsRegistry[id] = true;
nullComponentIDsRegistry[id] = true;
}

/**
* Unmark the component as having rendered to null: it renders to something now.
* @param {string} id Component's `_rootNodeID`.
*/
function deregisterNullComponentID(id) {
delete nullComponentIdsRegistry[id];
delete nullComponentIDsRegistry[id];
}

/**
* @param {string} id Component's `_rootNodeID`.
* @return {boolean} True if the component is rendered to null.
*/
function isNullComponentID(id) {
return !!nullComponentIdsRegistry[id];
return !!nullComponentIDsRegistry[id];
}

var ReactEmptyComponent = {
Expand Down