Skip to content

[Flight] Enable sync stack traces for errors and console replay#31270

Merged
sebmarkbage merged 1 commit intofacebook:mainfrom
sebmarkbage:sourcemaprsc
Oct 16, 2024
Merged

[Flight] Enable sync stack traces for errors and console replay#31270
sebmarkbage merged 1 commit intofacebook:mainfrom
sebmarkbage:sourcemaprsc

Conversation

@sebmarkbage
Copy link
Copy Markdown
Contributor

This was gated behind enableOwnerStacks since they share some code paths but it's really part of enableServerComponentLogs.

This just includes the server-side regular stack on Error/replayed logs but doesn't use console.createTask and doesn't include owner stacks.

@sebmarkbage sebmarkbage requested a review from eps1lon October 15, 2024 21:19
@vercel
Copy link
Copy Markdown

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:23pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 15, 2024
@react-sizebot
Copy link
Copy Markdown

Comparing: 6c4bbc783286bf6eebd9927cb52e8fec5ad4dd74...179c502813e6f56161578ceca645e6da9d36dc12

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 506.53 kB 506.53 kB = 90.68 kB 90.68 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 511.47 kB 511.47 kB = 91.40 kB 91.40 kB
facebook-www/ReactDOM-prod.classic.js = 603.93 kB 603.93 kB = 106.89 kB 106.89 kB
facebook-www/ReactDOM-prod.modern.js = 580.15 kB 580.15 kB = 102.97 kB 102.97 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-client/cjs/react-client-flight.development.js = 86.33 kB 86.02 kB = 16.05 kB 15.96 kB
oss-stable-rc/react-client/cjs/react-client-flight.development.js = 86.31 kB 85.99 kB = 16.03 kB 15.93 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js = 86.31 kB 85.99 kB = 16.03 kB 15.93 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 119.42 kB 118.76 kB = 28.14 kB 27.91 kB
oss-stable-rc/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 119.40 kB 118.74 kB = 28.12 kB 27.89 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 119.40 kB 118.74 kB = 28.12 kB 27.89 kB

Generated by 🚫 dangerJS against da8de9e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants