Moar warnings with solid prefixes! #3130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
force-pushed
the
identifiablewarnings
branch
from
d2f5a13 to
d9d3a66
Compare
This ensures that we have a prefix that can be easily identified in logs so that we can filter out warnings based on their prefix. This also turns the remaining two monitorCodeUse callers into warnings. We'll probably still use monitorCodeUse until we know if we want to deprecate but most releases should only have warnings.
sebmarkbage
force-pushed
the
identifiablewarnings
branch
from
d9d3a66 to
f503882
Compare
sebmarkbage
added a commit
that referenced
this pull request
Feb 12, 2015
Moar warnings with solid prefixes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we have a prefix that can be easily identified in logs
so that we can filter out warnings based on their prefix.
This also turns the remaining two monitorCodeUse callers into warnings.
We'll probably still use monitorCodeUse until we know if we want to
deprecate but most releases should only have warnings.