[Flight] Error names are not preserved #31335
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
eps1lon
commented
Oct 23, 2024
| `); | ||
| } else { | ||
| expect(ReactNoop).toMatchRenderedOutput(` | ||
| type: Error: An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error. |
Collaborator
Author
There was a problem hiding this comment.
In prod, we should probably not preserve the original constructor to not leak implementation details.
|
Comparing: 28668d39bea855c3bda481d018d8f3f0dfad9066...0e538e672963fdcee97bdc0c9ee07af1a37ecb1e Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Only failing test for now
I noticed some missing error names when we replay logged errors. Though that's different from what's in
error.stack. We do however drop the names of built-in errors which we should probably preserve. I haven't checked if structured clone preserves e.g.TypeErrorthough.How did you test this change?