[compiler] Outline jsx with duplicate attributes#31378
Closed
gsathya wants to merge 6 commits into
Closed
Conversation
Previously, we would skip outlining jsx expressions that had duplicate jsx attributes as we would not rename them causing incorrect compilation. In thir PR, we add outlining support for duplicate jsx attributes by renaming them. [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
Previously, we would skip outlining jsx expressions that had duplicate jsx attributes as we would not rename them causing incorrect compilation. In thir PR, we add outlining support for duplicate jsx attributes by renaming them. [ghstack-poisoned]
Previously, we would skip outlining jsx expressions that had duplicate jsx attributes as we would not rename them causing incorrect compilation. In thir PR, we add outlining support for duplicate jsx attributes by renaming them. [ghstack-poisoned]
Comment on lines
+9
to
+10
| <Foo k={i + 'i'}></Foo> | ||
| <Foo k={i + 'j'}></Foo> |
Member
There was a problem hiding this comment.
try adding a third child with <Foo k1={i + 'k'}></Foo>
josephsavona
approved these changes
Oct 30, 2024
Member
josephsavona
left a comment
josephsavona
left a comment
There was a problem hiding this comment.
Awesome! Just a couple things to address before landing
Previously, we would skip outlining jsx expressions that had duplicate jsx attributes as we would not rename them causing incorrect compilation. In thir PR, we add outlining support for duplicate jsx attributes by renaming them. [ghstack-poisoned]
josephsavona
approved these changes
Nov 1, 2024
Previously, we would skip outlining jsx expressions that had duplicate jsx attributes as we would not rename them causing incorrect compilation. In thir PR, we add outlining support for duplicate jsx attributes by renaming them. [ghstack-poisoned]
Previously, we would skip outlining jsx expressions that had duplicate jsx attributes as we would not rename them causing incorrect compilation. In thir PR, we add outlining support for duplicate jsx attributes by renaming them. [ghstack-poisoned]
gsathya
added a commit
to gsathya/react
that referenced
this pull request
Nov 6, 2024
Previously, we would skip outlining jsx expressions that had duplicate jsx attributes as we would not rename them causing incorrect compilation. In thir PR, we add outlining support for duplicate jsx attributes by renaming them. ghstack-source-id: 3777d99 Pull Request resolved: facebook#31378
gsathya
added a commit
to gsathya/react
that referenced
this pull request
Nov 6, 2024
Previously, we would skip outlining jsx expressions that had duplicate jsx attributes as we would not rename them causing incorrect compilation. In thir PR, we add outlining support for duplicate jsx attributes by renaming them. ghstack-source-id: 3777d99 Pull Request resolved: facebook#31378
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Previously, we would skip outlining jsx expressions that had duplicate
jsx attributes as we would not rename them causing incorrect
compilation.
In thir PR, we add outlining support for duplicate jsx attributes by
renaming them.