[Docs] Reword section on React without JSX#3167
Merged
sophiebits merged 1 commit intofacebook:masterfrom Feb 17, 2015
Merged
Conversation
Summary: This section was confusing. I reworded it from: "JSX is completely optional. You don't have to use JSX with React. You can create these trees through `React.createElement`. The first argument is the tag, pass a properties object as the second argument and children to the third argument." to: "JSX is completely optional; you don't have to use JSX with React. You can create React elements in plain JavaScript using `React.createElement`, which takes a tag name or component, a properties object, and variable number of optional child arguments." and additionally added another child element to the example code. Test Plan: Read the new paragraph!
Contributor
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Contributor
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Collaborator
|
Thanks! |
sophiebits
added a commit
that referenced
this pull request
Feb 17, 2015
[Docs] Reword section on React without JSX
sophiebits
added a commit
that referenced
this pull request
Feb 18, 2015
[Docs] Reword section on React without JSX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This section was confusing. I reworded it from:
"JSX is completely optional. You don't have to use JSX with React. You can create these trees through
React.createElement. The first argument is the tag, pass a properties object as the second argument and children to the third argument."to:
"JSX is completely optional; you don't have to use JSX with React. You can create React elements in plain JavaScript using
React.createElement, which takes a tag name or component, a properties object, and variable number of optional child arguments."and additionally added another child element to the example code.
Test Plan:
Read the new paragraph!