Skip to content

Set direction in animate call directly #32523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebmarkbage merged 1 commit into from
Mar 5, 2025
Merged

Set direction in animate call directly #32523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1754,7 +1754,7 @@ function animateGesture(
moveOldFrameIntoViewport(keyframes[0]);
}
const reverse = rangeStart > rangeEnd;
const anim = targetElement.animate(keyframes, {
targetElement.animate(keyframes, {
pseudoElement: pseudoElement,
// Set the timeline to the current gesture timeline to drive the updates.
timeline: timeline,
Expand All @@ -1764,20 +1764,14 @@ function animateGesture(
easing: 'linear',
// We fill in both direction for overscroll.
fill: 'both',
// We play all gestures in reverse, except if we're in reverse direction
// in which case we need to play it in reverse of the reverse.
direction: reverse ? 'normal' : 'reverse',
// Range start needs to be higher than range end. If it goes in reverse
// we reverse the whole animation below.
rangeStart: (reverse ? rangeEnd : rangeStart) + '%',
rangeEnd: (reverse ? rangeStart : rangeEnd) + '%',
});
if (!reverse) {
// We play all gestures in reverse, except if we're in reverse direction
// in which case we need to play it in reverse of the reverse.
anim.reverse();
// In Safari, there's a bug where the starting position isn't immediately
// picked up from the ScrollTimeline for one frame.
// $FlowFixMe[cannot-resolve-name]
anim.currentTime = CSS.percent(100);
}
}

export function startGestureTransition(
Expand Down