Skip to content

[eslint-plugin-react-compiler] fix recommended config usage with defineConfig#32622

Closed
kasmacioma wants to merge 1 commit intofacebook:mainfrom
kasmacioma:eslint-react-compiler-typings
Closed

[eslint-plugin-react-compiler] fix recommended config usage with defineConfig#32622
kasmacioma wants to merge 1 commit intofacebook:mainfrom
kasmacioma:eslint-react-compiler-typings

Conversation

@kasmacioma
Copy link

@kasmacioma kasmacioma commented Mar 15, 2025

Summary

Recently ESLint released defineConfig utility to work with flat configs. Now when using recommended config from eslint-plugin-react-compiler, a typing error appears because the severity for the react-compiler/react-compiler rule in the .d.ts file is of type string rather than the more specific "error". Here is a simple reproduction.

How did you test this change?

Just recreated the recommended config in TypeScript playground with the suggested changes

@facebook-github-bot
Copy link
Contributor

Hi @kosmotema!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants