[eslint-plugin-react-compiler] fix recommended config usage with defineConfig#32622
[eslint-plugin-react-compiler] fix recommended config usage with defineConfig#32622kasmacioma wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Hi @kosmotema! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Recently ESLint released
defineConfigutility to work with flat configs. Now when using recommended config fromeslint-plugin-react-compiler, a typing error appears because the severity for thereact-compiler/react-compilerrule in the .d.ts file is of typestringrather than the more specific"error". Here is a simple reproduction.How did you test this change?
Just recreated the recommended config in TypeScript playground with the suggested changes