Skip to content

Conversation

@jonhester
Copy link
Contributor

Fixes #3315

@jimfb
Copy link
Contributor

jimfb commented Mar 5, 2015

Looks good. Two minor changes.

  1. We should use the warning module instead of console.debug. For example usage, you can search our code base for 'warning' (https://github.com/facebook/react/search?utf8=%E2%9C%93&q=warning). The warning module takes in two arguments (the invariant condition and the message to display).
  2. We should wrap the call to warning in a if(__DEV__) block, as we do elsewhere in the code base (see same link).

@jonhester
Copy link
Contributor Author

@JSFB, thanks for the feedback. I changed it to use the warning module. I did not wrap it in an if(__DEV__) block, since it is already inside the one starting on line 102.

if (__DEV__) {
.

@jimfb
Copy link
Contributor

jimfb commented Mar 5, 2015

Great, looks good to me! @spicyj, any feedback?

We are in a code freeze for the next week-ish, so we'll prep this for merge once the code freeze ends.

jimfb added a commit that referenced this pull request Mar 10, 2015
warn if IE8 is in compatibility mode
@jimfb jimfb merged commit 645a6ca into facebook:master Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect IE8 Compatibility Mode

2 participants