[Flight] Improve owner and component stacks when aborting#34755
Closed
unstubbable wants to merge 2 commits into
Closed
[Flight] Improve owner and component stacks when aborting#34755unstubbable wants to merge 2 commits into
unstubbable wants to merge 2 commits into
Conversation
unstubbable
changed the title
github-actions
Bot
added
the
React Core Team
unstubbable
changed the title
unstubbable
force-pushed
the
improve-aborted-promise-stacks
branch
2 times, most recently
from
5e89b83 to
b174161
Compare
sebmarkbage
reviewed
Oct 6, 2025
unstubbable
force-pushed
the
improve-aborted-promise-stacks
branch
4 times, most recently
from
d785334 to
5454fe9
Compare
unstubbable
force-pushed
the
improve-aborted-promise-stacks
branch
3 times, most recently
from
70d31fe to
d26ae68
Compare
when scheduling prerendering and aborting in successive tasks using setImmediate ✕ includes deeper location for hanging promises ✓ includes deeper location for hanging promises in ignore-listed components ! includes deeper location for unresolved I/O (this one is flaky!) when scheduling prerendering and aborting in successive tasks using setTimeout ✓ includes deeper location for hanging promises ✕ includes deeper location for hanging promises in ignore-listed components ✕ includes deeper location for unresolved I/O
unstubbable
force-pushed
the
improve-aborted-promise-stacks
branch
from
d26ae68 to
6d836b3
Compare
Collaborator
Author
|
Closing, because we consider the RSC prerender/abort approach inferior to (pre)rendering RSC to completion and then aborting the Fizz prerender before releasing dynamic RSC chunks into the stream, see this test: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #34638, covering not only hanging promises, but also unresolved I/O. In fact, the stacks for hanging promises when aborting prerenders can already be fixed by defining a
displayNamefor those promises, as enabled by #34825. Therefore this PR does not change anything about those, and just adds tests to confirm the expected behavior in the prerender abort case.For unresolved I/O, we're adding special handling to the
async_hookstracking so that for aborted async functions (typically server components) we can find an unresolved await node that we can serialize as I/O node, and subsequently use for owner and component stacks, to indicate where the component suspended when the prerender was aborted.