Docs: do not render components to document.body#3483
Merged
zpao merged 1 commit intofacebook:masterfrom Mar 23, 2015
Merged
Conversation
Rendering to `document.body` in the examples is conveniently short, but it can be misleading at the same time, especially for newcomers. While it's possible to render React components to `document.body`, any 3rd party scripts can also mess up with it, and it can have unintended consequences and be source of difficult-to-trace bugs.
Collaborator
|
+1 been burned hard by this |
Member
|
👍 Thanks for this! |
zpao
added a commit
that referenced
this pull request
Mar 23, 2015
Docs: do not render components to `document.body`
zpao
added a commit
that referenced
this pull request
Apr 3, 2015
Docs: do not render components to `document.body`
dilberx
pushed a commit
to dilberx/react
that referenced
this pull request
Apr 15, 2026
Docs: do not render components to `document.body`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendering to
document.bodyin the examples is conveniently short, but it canbe misleading at the same time, especially for newcomers.
While it's possible to render React components to
document.body, any 3rdparty scripts can also mess up with it, and it can have unintended consequences
and be source of difficult-to-trace bugs.