Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Nov 27, 2025

Changes were necessary after #35201 to make e2e tests pass. CI didn't catch it because the PR got merged while CI was deactived.

Fixes https://github.com/eps1lon/react/actions/runs/19699507928/job/56432042571 and https://github.com/eps1lon/react/actions/runs/19699507928/job/56432042565

test plan

  • cd fixtures/eslint-v9 && yarn && node build.mjs && yarn lint
  • CI

@eps1lon eps1lon requested a review from josephsavona November 27, 2025 13:05
@meta-cla meta-cla bot added the CLA Signed label Nov 27, 2025
@eps1lon eps1lon changed the title [compiler] Update e2e tests [test] Update ESLint e2e tests Nov 27, 2025
@eps1lon eps1lon force-pushed the sebbie/11-27-_compiler_update_e2e_tests branch from c0de7b7 to 408daef Compare December 1, 2025 17:29
@eps1lon eps1lon force-pushed the sebbie/11-27-_compiler_update_e2e_tests branch from 408daef to 0a98f9e Compare December 1, 2025 17:34
@eps1lon eps1lon requested a review from poteto December 1, 2025 17:37
@eps1lon eps1lon marked this pull request as draft December 1, 2025 17:37
@eps1lon eps1lon marked this pull request as ready for review December 1, 2025 17:37
@react-sizebot
Copy link

Comparing: 1721e73...0a98f9e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 608.36 kB 608.36 kB = 107.68 kB 107.68 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 667.47 kB 667.47 kB = 117.57 kB 117.57 kB
facebook-www/ReactDOM-prod.classic.js = 693.67 kB 693.67 kB = 122.06 kB 122.06 kB
facebook-www/ReactDOM-prod.modern.js = 684.10 kB 684.10 kB = 120.45 kB 120.45 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0a98f9e

@eps1lon eps1lon merged commit 0af4fd8 into facebook:main Dec 1, 2025
241 checks passed
@eps1lon eps1lon deleted the sebbie/11-27-_compiler_update_e2e_tests branch December 1, 2025 18:04
github-actions bot pushed a commit that referenced this pull request Dec 1, 2025
github-actions bot pushed a commit that referenced this pull request Dec 1, 2025
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 3, 2025
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants