Skip to content

[test] Update ESLint e2e tests #35233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eps1lon merged 1 commit into from
Dec 1, 2025
+10 −8
Merged

[test] Update ESLint e2e tests #35233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fixtures/eslint-v6/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,9 @@ function InvalidGlobals() {
return <div>Done</div>;
}

// Invalid: useMemo with wrong deps - triggers preserve-manual-memoization
// Invalid: useMemo with wrong deps
function InvalidUseMemo({items}) {
// eslint-disable-next-line react-hooks/preserve-manual-memoization, react-hooks/exhaustive-deps
// eslint-disable-next-line react-hooks/exhaustive-deps
const sorted = useMemo(() => [...items].sort(), []);
return <div>{sorted.length}</div>;
}
4 changes: 2 additions & 2 deletions fixtures/eslint-v7/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,9 @@ function InvalidGlobals() {
return <div>Done</div>;
}

// Invalid: useMemo with wrong deps - triggers preserve-manual-memoization
// Invalid: useMemo with wrong deps
function InvalidUseMemo({items}) {
// eslint-disable-next-line react-hooks/preserve-manual-memoization, react-hooks/exhaustive-deps
// eslint-disable-next-line react-hooks/exhaustive-deps
const sorted = useMemo(() => [...items].sort(), []);
return <div>{sorted.length}</div>;
}
4 changes: 2 additions & 2 deletions fixtures/eslint-v8/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,9 @@ function InvalidGlobals() {
return <div>Done</div>;
}

// Invalid: useMemo with wrong deps - triggers preserve-manual-memoization
// Invalid: useMemo with wrong deps
function InvalidUseMemo({items}) {
// eslint-disable-next-line react-hooks/preserve-manual-memoization, react-hooks/exhaustive-deps
// eslint-disable-next-line react-hooks/exhaustive-deps
const sorted = useMemo(() => [...items].sort(), []);
return <div>{sorted.length}</div>;
}
6 changes: 4 additions & 2 deletions fixtures/eslint-v9/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ function ComponentWithoutDeclaringPropAsDep(props) {
console.log(props.foo);
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);
// eslint-disable-next-line react-hooks/void-use-memo
useMemo(() => {
console.log(props.foo);
// eslint-disable-next-line react-hooks/exhaustive-deps
Expand All @@ -82,6 +83,7 @@ function ComponentWithoutDeclaringPropAsDep(props) {
console.log(props.foo);
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);
// eslint-disable-next-line react-hooks/void-use-memo
React.useMemo(() => {
console.log(props.foo);
// eslint-disable-next-line react-hooks/exhaustive-deps
Expand Down Expand Up @@ -159,9 +161,9 @@ function InvalidGlobals() {
return <div>Done</div>;
}

// Invalid: useMemo with wrong deps - triggers preserve-manual-memoization
// Invalid: useMemo with wrong deps
function InvalidUseMemo({items}) {
// eslint-disable-next-line react-hooks/preserve-manual-memoization, react-hooks/exhaustive-deps
// eslint-disable-next-line react-hooks/exhaustive-deps
const sorted = useMemo(() => [...items].sort(), []);
return <div>{sorted.length}</div>;
}
Loading