Skip to content

Add text node support to FragmentInstance operations #35630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackpope wants to merge 1 commit into
base: main
Choose a base branch
from
+773 −76
Open

Add text node support to FragmentInstance operations #35630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 26 additions & 72 deletions fixtures/dom/src/components/fixtures/fragment-refs/GetClientRectsCase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,10 @@
import TestCase from '../../TestCase';
import Fixture from '../../Fixture';
import PrintRectsFragmentContainer from './PrintRectsFragmentContainer';

const React = window.React;
const {Fragment, useRef, useState} = React;

export default function GetClientRectsCase() {
const fragmentRef = useRef(null);
const [rects, setRects] = useState([]);
const getRects = () => {
const rects = fragmentRef.current.getClientRects();
setRects(rects);
};

return (
<TestCase title="getClientRects">
<TestCase.Steps>
Expand All @@ -26,74 +19,35 @@ export default function GetClientRectsCase() {
</TestCase.ExpectedResult>
<Fixture>
<Fixture.Controls>
<button onClick={getRects}>Print Rects</button>
<div style={{display: 'flex'}}>
<div
<PrintRectsFragmentContainer>
<span
style={{
position: 'relative',
width: '30vw',
height: '30vh',
width: '300px',
height: '250px',
backgroundColor: 'lightblue',
fontSize: 20,
border: '1px solid black',
marginBottom: '10px',
}}>
{rects.map(({x, y, width, height}, index) => {
const scale = 0.3;

return (
<div
key={index}
style={{
position: 'absolute',
top: y * scale,
left: x * scale,
width: width * scale,
height: height * scale,
border: '1px solid red',
boxSizing: 'border-box',
}}></div>
);
})}
</div>
<div>
{rects.map(({x, y, width, height}, index) => {
return (
<div>
{index} :: {`{`}x: {x}, y: {y}, width: {width}, height:{' '}
{height}
{`}`}
</div>
);
})}
</div>
</div>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed do
eiusmod tempor incididunt ut labore et dolore magna aliqua.
</span>
<div
style={{
width: '150px',
height: '100px',
backgroundColor: 'lightgreen',
border: '1px solid black',
}}></div>
<div
style={{
width: '500px',
height: '50px',
backgroundColor: 'lightpink',
border: '1px solid black',
}}></div>
</PrintRectsFragmentContainer>
</Fixture.Controls>
<Fragment ref={fragmentRef}>
<span
style={{
width: '300px',
height: '250px',
backgroundColor: 'lightblue',
fontSize: 20,
border: '1px solid black',
marginBottom: '10px',
}}>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed do
eiusmod tempor incididunt ut labore et dolore magna aliqua.
</span>
<div
style={{
width: '150px',
height: '100px',
backgroundColor: 'lightgreen',
border: '1px solid black',
}}></div>
<div
style={{
width: '500px',
height: '50px',
backgroundColor: 'lightpink',
border: '1px solid black',
}}></div>
</Fragment>
</Fixture>
</TestCase>
);
Expand Down
126 changes: 126 additions & 0 deletions fixtures/dom/src/components/fixtures/fragment-refs/PrintRectsFragmentContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
const React = window.React;
const {Fragment, useRef, useState} = React;

const colors = [
'#e74c3c',
'#3498db',
'#2ecc71',
'#9b59b6',
'#f39c12',
'#1abc9c',
];

export default function PrintRectsFragmentContainer({children}) {
const fragmentRef = useRef(null);
const [rects, setRects] = useState([]);

const getRects = () => {
const rectsResult = fragmentRef.current.getClientRects();
setRects(Array.from(rectsResult));
};

const getColor = index => colors[index % colors.length];

return (
<Fragment>
<div style={{marginBottom: '16px'}}>
<button
onClick={getRects}
style={{
padding: '8px 16px',
fontSize: '14px',
fontWeight: 'bold',
cursor: 'pointer',
}}>
Print Rects
</button>
{rects.length > 0 && (
<span style={{marginLeft: '12px', color: '#666'}}>
Found {rects.length} rect{rects.length !== 1 ? 's' : ''}
</span>
)}
</div>

<div style={{display: 'flex', gap: '20px', marginBottom: '16px'}}>
<div
style={{
position: 'relative',
width: '30vw',
height: '30vh',
border: '1px solid #ccc',
backgroundColor: '#fafafa',
borderRadius: '4px',
overflow: 'hidden',
}}>
{rects.length === 0 && (
<div
style={{
position: 'absolute',
top: '50%',
left: '50%',
transform: 'translate(-50%, -50%)',
color: '#999',
fontSize: '14px',
}}>
Click button to visualize rects
</div>
)}
{rects.map(({x, y, width, height}, index) => {
const scale = 0.3;
const color = getColor(index);

return (
<div
key={index}
style={{
position: 'absolute',
top: y * scale,
left: x * scale,
width: width * scale,
height: height * scale,
border: `2px solid ${color}`,
backgroundColor: `${color}22`,
boxSizing: 'border-box',
borderRadius: '2px',
}}
/>
);
})}
</div>

<div style={{flex: 1, fontSize: '13px', fontFamily: 'monospace'}}>
{rects.map(({x, y, width, height}, index) => {
const color = getColor(index);
return (
<div
key={index}
style={{
padding: '6px 10px',
marginBottom: '4px',
backgroundColor: '#f5f5f5',
borderLeft: `3px solid ${color}`,
borderRadius: '2px',
}}>
<span style={{color: '#666'}}>#{index}</span>{' '}
<span style={{color: '#333'}}>
x: {Math.round(x)}, y: {Math.round(y)}, w: {Math.round(width)}
, h: {Math.round(height)}
</span>
</div>
);
})}
</div>
</div>

<div
style={{
padding: '12px',
border: '1px dashed #ccc',
borderRadius: '4px',
backgroundColor: '#fff',
}}>
<Fragment ref={fragmentRef}>{children}</Fragment>
</div>
</Fragment>
);
}
Loading
Loading