Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jan 26, 2026

Follow-up to d5324f4

Flow narrows the ServerReferenceId to a string due to typeof check and then it can't assign the narrowed value to an opaque type.

Instead we don't make ServerReferenceId opaque like for the other configs.

@eps1lon eps1lon requested a review from unstubbable January 26, 2026 20:03
@meta-cla meta-cla bot added the CLA Signed label Jan 26, 2026
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jan 26, 2026
@eps1lon eps1lon force-pushed the sebbie/markup-server-reference-types branch from 7e6790c to 4f4b182 Compare January 26, 2026 20:06
@react-sizebot
Copy link

react-sizebot commented Jan 26, 2026

Comparing: 1068027...4f4b182

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 608.67 kB 608.67 kB = 107.63 kB 107.63 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.05% 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 674.60 kB 674.60 kB = 118.58 kB 118.58 kB
facebook-www/ReactDOM-prod.classic.js = 693.92 kB 693.92 kB = 121.98 kB 121.98 kB
facebook-www/ReactDOM-prod.modern.js = 684.31 kB 684.31 kB = 120.37 kB 120.37 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 4f4b182

@eps1lon eps1lon merged commit 8c34556 into facebook:main Jan 26, 2026
234 checks passed
@eps1lon eps1lon deleted the sebbie/markup-server-reference-types branch January 26, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants